Skip to content

[GH-2050] Geopandas.GeoSeries: Implement align=False for _row_wise_operation + support indexes#2057

Merged
jiayuasu merged 1 commit into
apache:masterfrom
petern48:fix_index_and_align
Jul 4, 2025
Merged

[GH-2050] Geopandas.GeoSeries: Implement align=False for _row_wise_operation + support indexes#2057
jiayuasu merged 1 commit into
apache:masterfrom
petern48:fix_index_and_align

Conversation

@petern48
Copy link
Copy Markdown
Member

@petern48 petern48 commented Jul 3, 2025

Did you read the Contributor Guide?

Is this PR related to a ticket?

What changes were proposed in this PR?

  • Fix the __init__ to support traditional pandas indexes
  • Implement align=False behavior using existing NATURAL_ORDER_COLUMN_NAME

How was this patch tested?

Added tests

Did this PR include necessary documentation updates?

  • Yes, I have updated the documentation.

Comment thread python/sedona/geopandas/geoseries.py
@petern48
Copy link
Copy Markdown
Member Author

petern48 commented Jul 3, 2025

The doc changes are simply to replicate the same example in the original geopandas doc string for simplicity. The original one I wrote didn't have an example of using index=

@petern48 petern48 marked this pull request as ready for review July 3, 2025 17:37
@petern48 petern48 requested a review from jiayuasu as a code owner July 3, 2025 17:37
@petern48 petern48 requested a review from zhangfengcdt July 3, 2025 17:37
Copy link
Copy Markdown
Member

@zhangfengcdt zhangfengcdt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiayuasu jiayuasu merged commit 406e352 into apache:master Jul 4, 2025
27 checks passed
@petern48 petern48 deleted the fix_index_and_align branch July 4, 2025 05:45
Kontinuation pushed a commit to Kontinuation/sedona that referenced this pull request Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Geopandas.GeoSeries: Implement align=False behavior for _row_wise_operation + support index

3 participants