Skip to content

[GH-2194] Move sedona.geopandas to sedona.spark.geopandas#2225

Merged
jiayuasu merged 4 commits intoapache:masterfrom
petern48:import_loc
Aug 5, 2025
Merged

[GH-2194] Move sedona.geopandas to sedona.spark.geopandas#2225
jiayuasu merged 4 commits intoapache:masterfrom
petern48:import_loc

Conversation

@petern48
Copy link
Contributor

@petern48 petern48 commented Aug 4, 2025

Did you read the Contributor Guide?

Is this PR related to a ticket?

What changes were proposed in this PR?

Move sedona.geopandas to sedona.spark.geopandas

How was this patch tested?

N/A

Did this PR include necessary documentation updates?

  • No. I need to discuss something about the docs with Feng, so fixing the docs will be in a separate PR.

@petern48
Copy link
Contributor Author

petern48 commented Aug 4, 2025

@jiayuasu I just pattern matched the structure of other existing directories, so I added replacement files at the deprecated location. e.g sedona/geopandas/geoseries.py importing the class from sedona.spark.geopandas.geoseries. I also did the same for base.py which is just an internal class. Not sure if that makes sense to also include in the old path. Should I remove any of these? Wasn't sure if these were all necessary.

@petern48 petern48 marked this pull request as ready for review August 4, 2025 22:23
@petern48 petern48 requested a review from jiayuasu as a code owner August 4, 2025 22:23
@jiayuasu
Copy link
Member

jiayuasu commented Aug 4, 2025

@petern48 Let's remove all deprecation warning. GeoPandas API on Sedona is not used by any actual release so far. No need to deprecate them. Just directly move everything to sedona.spark.geopandas.

@petern48
Copy link
Contributor Author

petern48 commented Aug 5, 2025

done

@jiayuasu jiayuasu merged commit b632606 into apache:master Aug 5, 2025
31 checks passed
@jiayuasu
Copy link
Member

jiayuasu commented Aug 5, 2025

@petern48 GeoPandas on Sedona doc is gone after this change

https://sedona.apache.org/latest-snapshot/api/pydocs/sedona.spark.html#subpackages

@petern48 petern48 deleted the import_loc branch August 5, 2025 05:19
@petern48
Copy link
Contributor Author

petern48 commented Aug 5, 2025

Yeah, I know. I probably should've said it more explicitly, but that's what I meant by this in the PR description

No. I need to discuss something about the docs with Feng, so fixing the docs will be in a separate PR.

It's also what that issue I linked above is about. There's a lot more broken sections than just geopandas and more changes I want to make about the existing docs that are "working." Some of it's based on my subjective opinion what's better, so I figured I'd just wait a week to talk through a few things with Feng and do it all together.

@jiayuasu Does it matter if we don't fix this right away? If it does, I can submit a short PR to fix a few import paths. Otherwise, I'd rather just leave it because I'll probably change nearby code again later.

@jiayuasu
Copy link
Member

jiayuasu commented Aug 5, 2025

@petern48 sure. Nothing urgent. We can fix it next week once Feng is back.

Kontinuation pushed a commit to Kontinuation/sedona that referenced this pull request Jan 21, 2026
…he#2225)

* move sedona/geopandas to sedona/spark/geopandas

* Fix all import paths in source code and tests

* Add import files in old location for backwards compatibility

* Revert "Add import files in old location for backwards compatibility"

This reverts commit 1ffb3a2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

import path sedona.geopandas warns of using a deprecated import path

2 participants