fix: remove unnecessary shellcheck ignores from actionlint#2739
Closed
zamadye wants to merge 2 commits intoapache:masterfrom
Closed
fix: remove unnecessary shellcheck ignores from actionlint#2739zamadye wants to merge 2 commits intoapache:masterfrom
zamadye wants to merge 2 commits intoapache:masterfrom
Conversation
jbampton
added
github_actions
Member
|
linking the issue: #2738 |
Member
|
@jbampton i think this is a bot, given the behavior in the issue and profile |
This comment was marked as spam.
This comment was marked as spam.
Member
|
Apache blocked this user in #2738 Added labels to this PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey, i noticed the actionlint pre-commit hook had a bunch of shellcheck ignores that aren't actually needed.
the main issues were:
all the other workflow files already use correctly, so removing the ignores should be fine now. let me know if you need anything else!