Skip to content

docs: fix broken links (#2763)#2767

Merged
jbampton merged 4 commits intoapache:masterfrom
Takch02:fix-broken-links
Mar 20, 2026
Merged

docs: fix broken links (#2763)#2767
jbampton merged 4 commits intoapache:masterfrom
Takch02:fix-broken-links

Conversation

@Takch02
Copy link
Contributor

@Takch02 Takch02 commented Mar 18, 2026

Fixes #2763

Copy link
Member

@jbampton jbampton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the link summary report:

https://github.com/apache/sedona/actions/runs/23233259359#summary-67531424578

We have 2 timeouts that we should ignore in lychee.toml

@jbampton
Copy link
Member

jbampton commented Mar 18, 2026

I see you fixed one but there is another couple of those kr broken links in the codebase:

sedona$ grep -rIl 'http://www\.kr\.\.' .
./docs/api/snowflake/vector-data/Geometry-Functions.md
./docs/api/sql/Geometry-Functions.md
./docs/api/flink/Geometry-Functions.md
sedona$ grep -rInH 'http://www\.kr\.\.' .
./docs/api/snowflake/vector-data/Geometry-Functions.md:185:| [ST_FrechetDistance](Measurement-Functions/ST_FrechetDistance.md) | Computes and returns discrete [Frechet Distance](https://en.wikipedia.org/wiki/Fr%C3%A9chet_distance) between the given two geometries, based on [Computing Discrete Frechet Distance](http://www.kr.... |
./docs/api/sql/Geometry-Functions.md:194:| [ST_FrechetDistance](Measurement-Functions/ST_FrechetDistance.md) | Double | Computes and returns discrete [Frechet Distance](https://en.wikipedia.org/wiki/Fr%C3%A9chet_distance) between the given two geometries, based on [Computing Discrete Frechet Distance](http://www.kr.... | v1.5.0 |
./docs/api/flink/Geometry-Functions.md:193:| [ST_FrechetDistance](Measurement-Functions/ST_FrechetDistance.md) | Double | Computes and returns discrete [Frechet Distance](https://en.wikipedia.org/wiki/Fr%C3%A9chet_distance) between the given two geometries, based on [Computing Discrete Frechet Distance](http://www.kr.... | v1.5.0 |

@Takch02
Copy link
Contributor Author

Takch02 commented Mar 18, 2026

Thanks for catching that, @jbampton! I missed those duplicate files. I've updated the remaining broken links with the correct PDF URL in the latest commit.

Could you please help trigger the CI run? Thanks again!

@jbampton
Copy link
Member

@Takch02 see my first review as well

@Takch02
Copy link
Contributor Author

Takch02 commented Mar 18, 2026

@Takch02 see my first review as well

I made a mistake. I added the URLs causing timeouts to 'lychee.toml' to ignore them.

@jbampton
Copy link
Member

That is what i wanted. No worries not a mistake

@jbampton jbampton self-requested a review March 18, 2026 13:31
@Takch02
Copy link
Contributor Author

Takch02 commented Mar 18, 2026

That is what i wanted. No worries not a mistake

Thank you!

Currently, 415 and 503 errors are occurring on 3 links in CI.
I visited them myself and confirmed that they are working normally.

@jbampton
Copy link
Member

That is what i wanted. No worries not a mistake

Thank you!

Currently, 415 and 503 errors are occurring on 3 links in CI. I visited them myself and confirmed that they are working normally.

The link checker test still passes. Those 3 links don't make the test fail.

I ran the CI links test again and they don't appear.

Copy link
Member

@jbampton jbampton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! 👍

@jbampton jbampton merged commit e01cd5c into apache:master Mar 20, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lychee link checker broken links

2 participants