[GH-2830] Adds Geography dual-dispatch to ST_NumGeometries#2851
Merged
jiayuasu merged 5 commits intoapache:masterfrom Apr 28, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Geography support for ST_NumGeometries by dual-dispatching the Spark SQL expression to the Geography implementation in common, with accompanying unit/integration tests and Geography SQL docs.
Changes:
- Implement Geography
numGeometriesincommonand add Java unit tests. - Update Spark SQL
ST_NumGeometriesexpression to resolve between Geometry vs Geography implementations. - Add Spark SQL Geography integration tests and new Geography API docs page + index entry.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| spark/common/src/test/scala/org/apache/sedona/sql/geography/GeographyFunctionTest.scala | Adds Spark SQL test cases validating ST_NumGeometries on Geography inputs. |
| spark/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/Functions.scala | Switches ST_NumGeometries to dual-dispatch (Geometry + Geography) using inferrableFunction1. |
| docs/api/sql/geography/Geography-Functions/ST_NumGeometries.md | Adds Geography-specific SQL documentation for ST_NumGeometries. |
| docs/api/sql/geography/Geography-Functions.md | Adds ST_NumGeometries to the Geography functions index table. |
| common/src/test/java/org/apache/sedona/common/Geography/FunctionTest.java | Adds Java unit tests for Geography numGeometries. |
| common/src/main/java/org/apache/sedona/common/geography/Functions.java | Introduces Geography numGeometries delegating to JTS. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
please resolve conflicts |
…upport.st_numgeometries
Member
|
Conflict again |
jiayuasu
approved these changes
Apr 27, 2026
…upport.st_numgeometries
jiayuasu
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a ticket?
[GH-XXX] my subject. Closes #<issue_number>What changes were proposed in this PR?
How was this patch tested?
Did this PR include necessary documentation updates?