[GH-2830] Adds Geography dual-dispatch to ST_Length#2854
Merged
jiayuasu merged 5 commits intoapache:masterfrom Apr 29, 2026
Merged
[GH-2830] Adds Geography dual-dispatch to ST_Length#2854jiayuasu merged 5 commits intoapache:masterfrom
jiayuasu merged 5 commits intoapache:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Geography support for ST_Length so Spark SQL can return geodesic length (meters, WGS84 spheroid) when the input is a Geography, while preserving existing planar Geometry behavior.
Changes:
- Add dual-dispatch for
ST_Lengthin Spark SQL expression resolution (Geometry vs Geography). - Implement
org.apache.sedona.common.geography.Functions.length(Geography)usingSpheroid.length(toJTS(g)). - Add unit/integration tests and new Geography SQL docs page for
ST_Length.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| spark/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/Functions.scala | Adds Geography overload to ST_Length expression via inferred overload resolution. |
| common/src/main/java/org/apache/sedona/common/geography/Functions.java | Introduces geodesic length(Geography) implementation (WGS84 spheroid via Spheroid). |
| common/src/test/java/org/apache/sedona/common/Geography/FunctionTest.java | Adds core-module tests for geodesic length (equator/meridian/point/null). |
| spark/common/src/test/scala/org/apache/sedona/sql/geography/GeographyFunctionTest.scala | Adds Spark SQL integration tests for ST_Length on Geography. |
| docs/api/sql/geography/Geography-Functions/ST_Length.md | Adds Geography function documentation for ST_Length. |
| docs/api/sql/geography/Geography-Functions.md | Adds ST_Length entry to the Geography functions index. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jiayuasu
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a ticket?
[GH-XXX] my subject. Closes #<issue_number>What changes were proposed in this PR?
How was this patch tested?
Did this PR include necessary documentation updates?