Merged
Conversation
yhs0092
requested changes
May 29, 2019
|
|
||
| ```Java | ||
| ConfigNoAnnotation config = new ConfigObjectFactory().create(ConfigNoAnnotation.class); | ||
| ConfigNoAnnotation config = priorityPropertyManager.createConfigObject(ConfigNoAnnotation.class); |
Member
There was a problem hiding this comment.
It's better to show how to get the instance of PriorityPropertyManager. You can get example from org.apache.servicecomb.core.definition.OperationMeta#init, a config object is created here : )
Member
There was a problem hiding this comment.
And there is no such method in PriorityPropertyManager. Please keep the demo code correct and as less misleading as possible.
pengliang56
force-pushed
the
ConfigInject-DocModify
branch
2 times, most recently
from
279be9e to
c23b680
Compare
yhs0092
reviewed
May 29, 2019
| ); | ||
| ``` | ||
|
|
||
| 最后不管是有无注解的属性注入，都要显示的回收对象PriorityPropertyManager |
Member
There was a problem hiding this comment.
都要"显式地"回收配置注入对象
fix typo, and the objects should be collected are the injected ConfigObject instances, instead of the PriorityPropertyManager
pengliang56
force-pushed
the
ConfigInject-DocModify
branch
from
c23b680 to
abd69c6
Compare
pengliang56
force-pushed
the
ConfigInject-DocModify
branch
from
abd69c6 to
e8fc1b9
Compare
yhs0092
approved these changes
May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.