Skip to content

[SCB-1045]fix sample spring bean declaring#1010

Merged
wujimin merged 1 commit intoapache:masterfrom
heyile:cpuAndNet
Nov 26, 2018
Merged

[SCB-1045]fix sample spring bean declaring#1010
wujimin merged 1 commit intoapache:masterfrom
heyile:cpuAndNet

Conversation

@heyile
Copy link
Contributor

@heyile heyile commented Nov 26, 2018

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Copy link
Member

@asifdxtreme asifdxtreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wujimin wujimin merged commit 2775f48 into apache:master Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants