[SCB-1079]allow consumer-id to be empty when query instance#1036
Merged
liubao68 merged 1 commit intoapache:masterfrom Dec 18, 2018
liubao68:reg-instance
Merged
[SCB-1079]allow consumer-id to be empty when query instance#1036liubao68 merged 1 commit intoapache:masterfrom liubao68:reg-instance
liubao68 merged 1 commit intoapache:masterfrom
liubao68:reg-instance
Conversation
Member
|
Hi @liubao68 |
Contributor
Author
|
@yhs0092 consumer-id is null when the startup procedure is in progress (BEFORE_REGISTRY), the service-id is not registered to service-center or we have not quried service-id from service-center. This feature is for scenarios that users want to do some extra control before register himself. e.g. Registry before querie service center that some dependeded service exists. |
wujimin
approved these changes
Dec 18, 2018
Member
|
@liubao68 OK, get it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean installto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.