Skip to content

[SCB-1079]allow consumer-id to be empty when query instance#1036

Merged
liubao68 merged 1 commit intoapache:masterfrom
liubao68:reg-instance
Dec 18, 2018
Merged

[SCB-1079]allow consumer-id to be empty when query instance#1036
liubao68 merged 1 commit intoapache:masterfrom
liubao68:reg-instance

Conversation

@liubao68
Copy link
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 86.696% when pulling a83f380 on liubao68:reg-instance into bd6a2c4 on apache:master.

@yhs0092
Copy link
Member

yhs0092 commented Dec 14, 2018

Hi @liubao68
As far as I know, we treat service-id of the consumer as the consumer-id. So there seems no possibility that the consumer-id is null, as long as the consumer service instance is registered in service-center properly.
Or the service-id mechanism will also be changed?

@liubao68
Copy link
Contributor Author

@yhs0092 consumer-id is null when the startup procedure is in progress (BEFORE_REGISTRY), the service-id is not registered to service-center or we have not quried service-id from service-center. This feature is for scenarios that users want to do some extra control before register himself. e.g. Registry before querie service center that some dependeded service exists.

@liubao68 liubao68 merged commit 8b7bc87 into apache:master Dec 18, 2018
@yhs0092
Copy link
Member

yhs0092 commented Dec 18, 2018

@liubao68 OK, get it.

@liubao68 liubao68 deleted the reg-instance branch March 9, 2021 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants