Skip to content

[SCB-1202]pump down with vertx3.6.3 no need to check buff length in A…#1131

Merged
wujimin merged 1 commit intoapache:masterfrom
heyile:pumpDown
Mar 18, 2019
Merged

[SCB-1202]pump down with vertx3.6.3 no need to check buff length in A…#1131
wujimin merged 1 commit intoapache:masterfrom
heyile:pumpDown

Conversation

@heyile
Copy link
Contributor

@heyile heyile commented Mar 16, 2019

…synFileImpl#doWrite

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

coveralls commented Mar 16, 2019

Coverage Status

Coverage increased (+0.03%) to 85.545% when pulling 59d8e26 on heyile:pumpDown into 27e73d2 on apache:master.

@wujimin wujimin merged commit b56b0f5 into apache:master Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants