[SCB-1229] update the version of dependency#1158
Conversation
heyile
force-pushed
the
updateDependency
branch
from
cad7ea6 to
bb0c85f
Compare
heyile
force-pushed
the
updateDependency
branch
from
bb0c85f to
011a9d9
Compare
|
Does license files need upgrated? see #1149 |
|
|
We need to merge this patch and regenerate the license information for it. |
|
If we don't plan to merge it before the java-chassis 1.2.0 release. I will merge the License fix #1163 shortly. |
heyile
force-pushed
the
updateDependency
branch
2 times, most recently
from
5eb734a to
d21a6a8
Compare
|
|
||
| if (Closeable.class.isInstance(operationMeta.getExecutor())) { | ||
| IOUtils.closeQuietly((Closeable) operationMeta.getExecutor()); | ||
| Closeable executor = (Closeable) operationMeta.getExecutor(); |
There was a problem hiding this comment.
seems they are doing the same thing
why need the change?
There was a problem hiding this comment.
IOUtils.closeQuietly() is deprecated in commons-io 2.6
| part.saveToFile(file.getAbsolutePath()).get(); | ||
|
|
||
| Assert.assertEquals(src, FileUtils.readFileToString(file)); | ||
| Assert.assertEquals(src, FileUtils.readFileToString(file, Charset.defaultCharset())); |
There was a problem hiding this comment.
replace all defaultCharset to UTF_8?
There was a problem hiding this comment.
done. replace all defaultCharset with UTF_8
| private GlobalRegistry globalRegistry; | ||
|
|
||
| private ServoRegistry registry; | ||
| @SuppressWarnings("deprecation") |
There was a problem hiding this comment.
seems that we did not strong depend servo
no need to keep it? change to another one?
There was a problem hiding this comment.
I have create a new issue about it. https://issues.apache.org/jira/browse/SCB-1245 and now, do not have enough time about it
5 participants
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean install -Pitto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.