Skip to content

[SCB-1305] CseAysncRestTemplate is not set headers#1229

Merged
liubao68 merged 2 commits intoapache:masterfrom
wangshenggh:master
Jun 20, 2019
Merged

[SCB-1305] CseAysncRestTemplate is not set headers#1229
liubao68 merged 2 commits intoapache:masterfrom
wangshenggh:master

Conversation

@wangshenggh
Copy link
Copy Markdown
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link
Copy Markdown

coveralls commented May 31, 2019

Coverage Status

Coverage increased (+0.02%) to 85.689% when pulling 6b6947b on wangshenggh:master into 80a13dd on apache:master.

Copy link
Copy Markdown
Contributor

@wujimin wujimin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add integration test.

@heyile
Copy link
Copy Markdown
Contributor

heyile commented Jun 19, 2019

UT should cover all the scenes that we may meet.

@liubao68 liubao68 merged commit 6d5d662 into apache:master Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants