Skip to content

[SCB-1297] NPE would be arised if you haven't set any value for servicecomb.config.ignoreResolveFailure#1293

Closed
HuaiJoe wants to merge 2 commits intoapache:masterfrom
HuaiJoe:master
Closed

[SCB-1297] NPE would be arised if you haven't set any value for servicecomb.config.ignoreResolveFailure#1293
HuaiJoe wants to merge 2 commits intoapache:masterfrom
HuaiJoe:master

Conversation

@HuaiJoe
Copy link
Contributor

@HuaiJoe HuaiJoe commented Aug 10, 2019

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@yhs0092
Copy link
Member

yhs0092 commented Aug 12, 2019

Hi, the CI seems fail. Could you fix it? You can run the integration test by running mvn clean install -Pit in the root directory of the project. And the IT requires a local service-center running in your development environment.
And it's suggested that the jira issue Key should be added into the commit message as prefix. You can see the commit message format in the former PR of this issue : )

@HuaiJoe HuaiJoe closed this Aug 12, 2019
@HuaiJoe HuaiJoe deleted the master branch August 12, 2019 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants