Skip to content

[SCB-1297] NPE would be arised if you haven't set any value for servicecomb.config.ignoreResolveFailure #1294

Merged
yhs0092 merged 2 commits intoapache:masterfrom
HuaiJoe:master
Aug 15, 2019
Merged

[SCB-1297] NPE would be arised if you haven't set any value for servicecomb.config.ignoreResolveFailure #1294
yhs0092 merged 2 commits intoapache:masterfrom
HuaiJoe:master

Conversation

@HuaiJoe
Copy link
Contributor

@HuaiJoe HuaiJoe commented Aug 12, 2019

…vicecomb.config.ignoreResolveFailure

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@yhs0092
Copy link
Member

yhs0092 commented Aug 14, 2019

#1292

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 85.755% when pulling 4660a20 on HuaiJoe:master into bc333c5 on apache:master.

@yhs0092 yhs0092 merged commit 55b0f16 into apache:master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants