Skip to content

[SCB-1450] Microservice instance may get stuck when watch connection to sc is recovered and pulling instance action is executed in eventloop thread#1301

Merged
yhs0092 merged 3 commits intoapache:masterfrom
HuaiJoe:master
Aug 29, 2019
Merged

[SCB-1450] Microservice instance may get stuck when watch connection to sc is recovered and pulling instance action is executed in eventloop thread#1301
yhs0092 merged 3 commits intoapache:masterfrom
HuaiJoe:master

Conversation

@HuaiJoe
Copy link
Copy Markdown
Contributor

@HuaiJoe HuaiJoe commented Aug 20, 2019

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

…rticle,So it can support blocking-task,like Service Center watching task.
…to servicecomb.service.registry.client.instance for workerPoolSize can not indicate how many verticle instances had been deployed.
@coveralls
Copy link
Copy Markdown

coveralls commented Aug 22, 2019

Coverage Status

Coverage increased (+0.1%) to 85.896% when pulling 296b005 on HuaiJoe:master into 350e988 on apache:master.

@liubao68
Copy link
Copy Markdown
Contributor

Can you please check if config-cc has the same problem?

@HuaiJoe
Copy link
Copy Markdown
Contributor Author

HuaiJoe commented Aug 28, 2019

Can you please check if config-cc has the same problem?

Config Center client may come across the same problem as Service Center client.I will create a issue and fix it later.

@yhs0092 yhs0092 merged commit 686395a into apache:master Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants