[SCB-1450] Microservice instance may get stuck when watch connection to sc is recovered and pulling instance action is executed in eventloop thread#1301
Merged
yhs0092 merged 3 commits intoapache:masterfrom Aug 29, 2019
Conversation
…rticle,So it can support blocking-task,like Service Center watching task.
…to servicecomb.service.registry.client.instance for workerPoolSize can not indicate how many verticle instances had been deployed.
liubao68
reviewed
Aug 25, 2019
...istry/src/main/java/org/apache/servicecomb/serviceregistry/config/ServiceRegistryConfig.java
Outdated
Show resolved
Hide resolved
liubao68
reviewed
Aug 25, 2019
...try/src/main/java/org/apache/servicecomb/serviceregistry/client/http/AbstractClientPool.java
Outdated
Show resolved
Hide resolved
yhs0092
reviewed
Aug 25, 2019
...try/src/main/java/org/apache/servicecomb/serviceregistry/client/http/AbstractClientPool.java
Outdated
Show resolved
Hide resolved
yhs0092
reviewed
Aug 25, 2019
...istry/src/main/java/org/apache/servicecomb/serviceregistry/config/ServiceRegistryConfig.java
Outdated
Show resolved
Hide resolved
Contributor
|
Can you please check if config-cc has the same problem? |
yhs0092
approved these changes
Aug 28, 2019
Contributor
Author
Config Center client may come across the same problem as Service Center client.I will create a issue and fix it later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean install -Pitto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.