[SCB-1528] Optimizing some code implementations#1353
Merged
yhs0092 merged 1 commit intoapache:masterfrom Oct 23, 2019
Merged
Conversation
Contributor
Author
|
liubao68
reviewed
Oct 17, 2019
| public void onBootEvent(BootEvent bootEvent) { | ||
| if (bootEvent.getEventType() == EventType.BEFORE_REGISTRY) { | ||
| MicroserviceVersionRule rule = RegistryUtils.getServiceRegistry().getAppManager() | ||
| .getOrCreateMicroserviceVersionRule(RegistryUtils.getAppId(), "it-producer", "0+"); |
Contributor
There was a problem hiding this comment.
This test case is useful that we must gurrantee we can call getOrCreateMicroserviceVersionRule after BEFORE_REGISTRY without exception throw in bootup.
b8184ba to
ae891fb
Compare
liubao68
reviewed
Oct 22, 2019
| LOGGER.warn("Prefetch not successful, maybe the provider not started."); | ||
| } | ||
| @Override | ||
| public void onBootEvent(BootEvent bootEvent) { |
Contributor
There was a problem hiding this comment.
It seems this code does not use servicecomb recommented formatter.
liubao68
approved these changes
Oct 23, 2019
yhs0092
approved these changes
Oct 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean install -Pitto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.