Skip to content

[SCB-1610] add updateInstanceStatus to ServiceRegistryClient.java#1401

Merged
liubao68 merged 1 commit intoapache:masterfrom
merryzsp:master
Nov 25, 2019
Merged

[SCB-1610] add updateInstanceStatus to ServiceRegistryClient.java#1401
liubao68 merged 1 commit intoapache:masterfrom
merryzsp:master

Conversation

@merryzsp
Copy link
Copy Markdown

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 20, 2019

Coverage Status

Coverage decreased (-0.1%) to 85.861% when pulling 8759867 on merryzsp:master into 4e70461 on apache:master.

@liubao68 liubao68 changed the title #add updateInstanceStatus to ServiceRegistryClient.java [SCB-1610] add updateInstanceStatus to ServiceRegistryClient.java Nov 20, 2019
@liubao68
Copy link
Copy Markdown
Contributor

I create a issue to track this and updated this title. Can you do the following ?

  1. format the code using /etc foler code template
  2. rebase and push again to help better merge the PR (This can help mantain all commits or we have to do a merge).

@merryzsp
Copy link
Copy Markdown
Author

I create a issue to track this and updated this title. Can you do the following ?

  1. format the code using /etc foler code template
  2. rebase and push again to help better merge the PR (This can help mantain all commits or we have to do a merge).

我没有理解到你的意思 是说代码没有格式化么?还是说要做什么其他操作?

@liubao68
Copy link
Copy Markdown
Contributor

I create a issue to track this and updated this title. Can you do the following ?

  1. format the code using /etc foler code template
  2. rebase and push again to help better merge the PR (This can help mantain all commits or we have to do a merge).

我没有理解到你的意思 是说代码没有格式化么?还是说要做什么其他操作?

是的,少量代码没有格式化,建议适用项目提供的模板格式化一下。 第二个问题是指提交PR的分支可能不是基于master拉的,或者中间隔了几个commit,虽然也可以通过merge的方式合并,但是会丢失commit信息,可以进行一下rebase,保证可以在合入的时候,保留commit信息。
image

return false;
}
Map<String, String[]> queryParams = new HashMap<>();
queryParams.put("value",new String[]{status});
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code not well formated

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@liubao68 liubao68 merged commit 03112df into apache:master Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants