[SCB-2084] ServiceComb support dtm#1961
Merged
liubao68 merged 3 commits intoapache:masterfrom Sep 18, 2020
Merged
Conversation
liubao68
reviewed
Sep 17, 2020
| } | ||
| } | ||
| } catch (Throwable e) { | ||
| // ignore |
Contributor
There was a problem hiding this comment.
It's better to add a log. If this happens , maybe some bug, do not hide it.
liubao68
reviewed
Sep 17, 2020
| public void init(MicroserviceMeta microserviceMeta, InvocationType invocationType) { | ||
| try { | ||
| Class<?> clazz = Class.forName("com.huawei.middleware.dtm.client.context.DTMContext"); | ||
| dtmContextExMethod = clazz.getMethod("getContextData"); |
Contributor
There was a problem hiding this comment.
suggestions: class name can be configurable, so that can be easier tested and tollerate to changes.
liubao68
reviewed
Sep 17, 2020
Comment on lines
+41
to
+45
| classNameProperty.addCallback(() -> { | ||
| donInitMethod(classNameProperty.getString()); | ||
| LOG.info("Dtm context class name update, value = [{}]", classNameProperty.getString()); | ||
| }); | ||
| } |
Contributor
There was a problem hiding this comment.
callback seems useless. Implementation class is compiled and packaged with application, can not be chagned in runtime.
liubao68
approved these changes
Sep 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean install -Pitto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.