Skip to content

Scb 2128 support dynamic single value enum#2080

Merged
liubao68 merged 2 commits intoapache:masterfrom
wujimin:SCB-2128-support-dynamic-single-value-enum
Nov 27, 2020
Merged

Scb 2128 support dynamic single value enum#2080
liubao68 merged 2 commits intoapache:masterfrom
wujimin:SCB-2128-support-dynamic-single-value-enum

Conversation

@wujimin
Copy link
Contributor

@wujimin wujimin commented Nov 25, 2020

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@wujimin wujimin requested review from liubao68 and yhs0092 November 25, 2020 17:09
@wujimin wujimin force-pushed the SCB-2128-support-dynamic-single-value-enum branch 2 times, most recently from dc55c8d to a0decad Compare November 26, 2020 01:08
@wujimin wujimin force-pushed the SCB-2128-support-dynamic-single-value-enum branch from a0decad to 2932e1a Compare November 26, 2020 14:21
@codecov-io
Copy link

Codecov Report

Merging #2080 (2932e1a) into master (593a3a4) will decrease coverage by 0.02%.
The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2080      +/-   ##
============================================
- Coverage     81.52%   81.49%   -0.03%     
- Complexity     1297     1308      +11     
============================================
  Files          1434     1441       +7     
  Lines         39219    39411     +192     
  Branches       3334     3353      +19     
============================================
+ Hits          31974    32119     +145     
- Misses         5790     5826      +36     
- Partials       1455     1466      +11     
Impacted Files Coverage Δ Complexity Δ
...l/schema/deserializer/scalar/EnumsReadSchemas.java 54.34% <0.00%> (-13.22%) 0.00 <0.00> (ø)
...nal/schema/serializer/scalar/EnumWriteSchemas.java 86.53% <0.00%> (-5.30%) 0.00 <0.00> (ø)
...ervicecomb/foundation/common/base/DynamicEnum.java 45.45% <45.45%> (ø) 0.00 <0.00> (?)
.../servicecomb/foundation/common/base/EnumUtils.java 57.14% <57.14%> (ø) 0.00 <0.00> (?)
...ecomb/foundation/common/base/DynamicEnumCache.java 66.66% <66.66%> (ø) 0.00 <0.00> (?)
...comb/swagger/extend/PropertyModelConverterExt.java 93.75% <93.75%> (ø) 0.00 <0.00> (?)
...apache/servicecomb/swagger/extend/SwaggerEnum.java 94.11% <94.11%> (ø) 0.00 <0.00> (?)
.../org/apache/servicecomb/it/junit/ITJUnitUtils.java 67.90% <100.00%> (+0.40%) 25.00 <1.00> (+1.00)
...servicecomb/it/testcase/TestDataTypePrimitive.java 100.00% <100.00%> (ø) 160.00 <8.00> (+8.00)
...a/org/apache/servicecomb/swagger/SwaggerUtils.java 93.47% <100.00%> (+0.10%) 0.00 <0.00> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 593a3a4...2932e1a. Read the comment docs.

@liubao68 liubao68 merged commit 4f58467 into apache:master Nov 27, 2020
@wujimin wujimin deleted the SCB-2128-support-dynamic-single-value-enum branch December 16, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants