Skip to content

add an example and test case for same class/interface name#2093

Merged
liubao68 merged 1 commit intoapache:masterfrom
liubao68:liubao
Dec 1, 2020
Merged

add an example and test case for same class/interface name#2093
liubao68 merged 1 commit intoapache:masterfrom
liubao68:liubao

Conversation

@liubao68
Copy link
Copy Markdown
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 30, 2020

Codecov Report

Merging #2093 (e793e57) into master (cbd4c57) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2093      +/-   ##
============================================
+ Coverage     81.54%   81.56%   +0.02%     
- Complexity     1327     1329       +2     
============================================
  Files          1442     1443       +1     
  Lines         39501    39507       +6     
  Branches       3353     3353              
============================================
+ Hits          32210    32225      +15     
+ Misses         5825     5817       -8     
+ Partials       1466     1465       -1     
Impacted Files Coverage Δ Complexity Δ
.../servicecomb/demo/pojo/client/TestSameService.java 100.00% <100.00%> (ø) 2.00 <2.00> (?)
...mb/serviceregistry/client/http/RestClientUtil.java 75.70% <0.00%> (-1.87%) 0.00% <0.00%> (ø%)
...egistry/client/http/ServiceRegistryClientImpl.java 70.87% <0.00%> (+0.77%) 0.00% <0.00%> (ø%)
...mb/serviceregistry/task/MicroserviceWatchTask.java 70.00% <0.00%> (+1.66%) 0.00% <0.00%> (ø%)
...ervicecomb/foundation/vertx/tcp/TcpConnection.java 86.48% <0.00%> (+2.70%) 0.00% <0.00%> (ø%)
...rviceregistry/client/http/WebsocketClientUtil.java 77.19% <0.00%> (+3.50%) 0.00% <0.00%> (ø%)
...cecomb/serviceregistry/task/ServiceCenterTask.java 89.79% <0.00%> (+6.12%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbd4c57...e793e57. Read the comment docs.

@liubao68 liubao68 merged commit b768f21 into apache:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants