Skip to content

[SCB-2135]provider flow control support for operation to any client s…#2098

Merged
wujimin merged 1 commit into
apache:masterfrom
liubao68:liubao
Dec 3, 2020
Merged

[SCB-2135]provider flow control support for operation to any client s…#2098
wujimin merged 1 commit into
apache:masterfrom
liubao68:liubao

Conversation

@liubao68
Copy link
Copy Markdown
Contributor

@liubao68 liubao68 commented Dec 3, 2020

…ervice

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@liubao68 liubao68 requested review from wujimin and yhs0092 December 3, 2020 07:48
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2098 (3897f83) into master (66e4947) will increase coverage by 0.00%.
The diff coverage is 92.13%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2098   +/-   ##
=========================================
  Coverage     81.53%   81.53%           
- Complexity     1329     1336    +7     
=========================================
  Files          1443     1444    +1     
  Lines         39534    39571   +37     
  Branches       3352     3356    +4     
=========================================
+ Hits          32234    32266   +32     
- Misses         5833     5837    +4     
- Partials       1467     1468    +1     
Impacted Files Coverage Δ Complexity Δ
.../servicecomb/qps/strategy/FixedWindowStrategy.java 66.66% <0.00%> (-16.67%) 0.00 <0.00> (ø)
...ecomb/provider/pojo/PojoConsumerMetaRefresher.java 78.04% <0.00%> (+2.43%) 0.00 <0.00> (ø)
.../servicecomb/qps/strategy/LeakyBucketStrategy.java 84.21% <50.00%> (+4.21%) 0.00 <0.00> (ø)
.../servicecomb/demo/pojo/client/TestFlowControl.java 92.30% <92.30%> (ø) 7.00 <7.00> (?)
...g/apache/servicecomb/qps/QpsControllerManager.java 78.29% <95.00%> (+3.29%) 0.00 <0.00> (ø)
...in/java/org/apache/servicecomb/core/SCBEngine.java 77.64% <100.00%> (ø) 0.00 <0.00> (ø)
...c/main/java/org/apache/servicecomb/qps/Config.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...servicecomb/qps/ConsumerQpsFlowControlHandler.java 75.00% <100.00%> (-3.58%) 0.00 <0.00> (ø)
...servicecomb/qps/ProviderQpsFlowControlHandler.java 87.50% <100.00%> (-3.41%) 0.00 <0.00> (ø)
...omb/swagger/invocation/response/ResponsesMeta.java 88.63% <100.00%> (+0.83%) 0.00 <0.00> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66e4947...3897f83. Read the comment docs.

@wujimin wujimin merged commit 3cb3649 into apache:master Dec 3, 2020
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.13483% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.53%. Comparing base (66e4947) to head (3897f83).
⚠️ Report is 1805 commits behind head on master.

Files with missing lines Patch % Lines
.../servicecomb/demo/pojo/client/TestFlowControl.java 92.30% 1 Missing and 1 partial ⚠️
...g/apache/servicecomb/qps/QpsControllerManager.java 95.00% 2 Missing ⚠️
.../servicecomb/qps/strategy/FixedWindowStrategy.java 0.00% 1 Missing ⚠️
.../servicecomb/qps/strategy/LeakyBucketStrategy.java 50.00% 1 Missing ⚠️
...ecomb/provider/pojo/PojoConsumerMetaRefresher.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2098   +/-   ##
=========================================
  Coverage     81.53%   81.53%           
- Complexity     1329     1336    +7     
=========================================
  Files          1443     1444    +1     
  Lines         39534    39571   +37     
  Branches       3352     3356    +4     
=========================================
+ Hits          32234    32266   +32     
- Misses         5833     5837    +4     
- Partials       1467     1468    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants