[SCB-2237] allow InjectProperties inject to spring bean instance#2314
Merged
liubao68 merged 1 commit intoapache:masterfrom Mar 27, 2021
Merged
Conversation
wujimin
force-pushed
the
SCB-2237-make-code-of-PriorityProperty-easier-to-read
branch
from
174693d to
fe9693d
Compare
wujimin
changed the title
liubao68
reviewed
Mar 27, 2021
| ## limitations under the License. | ||
| ## --------------------------------------------------------------------------- | ||
|
|
||
| servicecomb-config-order: -1000 |
Contributor
Author
There was a problem hiding this comment.
discovery client alway invoke with endpoint, no need other logic, eg: auth client
liubao68
reviewed
Mar 27, 2021
| } | ||
|
|
||
| public void setEnabled(boolean enabled) { | ||
| public InspectorConfig setEnabled(boolean enabled) { |
Contributor
There was a problem hiding this comment.
Can you add this usage for this feature to demo / integration tests? so that we can add documents using the demo.
Contributor
Author
There was a problem hiding this comment.
it's a shortcut for https://docs.servicecomb.io/java-chassis/zh_CN/config/read-config/
declare a class with @InjectProperties to be a bean, that's enough.
wujimin
deleted the
SCB-2237-make-code-of-PriorityProperty-easier-to-read
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not create multiple PriorityProperty instances for same parameter
refresh all instances after configuration changed
allow InjectProperties inject to spring bean instance