[#2381]fix initLatestVersion method#2384
Merged
liubao68 merged 2 commits intoapache:masterfrom May 27, 2021
Merged
Conversation
liubao68
reviewed
May 17, 2021
Comment on lines
148
to
158
| TagItem latestVersionTag = RouterRuleCache.getServiceInfoCacheMap().get(serviceName).getLatestVersionTag(); | ||
|
|
||
| if (latestVersionTag != null) { | ||
| for (T server : list) { | ||
| E ms = getIns.apply(server); | ||
| if (getVersion.apply(ms).equals(latestVersionTag.getVersion())) { | ||
| return; | ||
| } | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Maybe it's better to using API's in foundation-registry to find latest version.
While now, line 148~158 can be deleted, since if you check version match, will call getIns always, it it some as delete all these lines.
liubao68
approved these changes
May 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.