Skip to content

[SCB-2289]support disable swagger data type check and use generics#2450

Merged
liubao68 merged 1 commit intoapache:masterfrom
liubao68:generic
Jul 6, 2021
Merged

[SCB-2289]support disable swagger data type check and use generics#2450
liubao68 merged 1 commit intoapache:masterfrom
liubao68:generic

Conversation

@liubao68
Copy link
Contributor

@liubao68 liubao68 commented Jul 5, 2021

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #2450 (7ef614f) into master (a063df5) will increase coverage by 0.00%.
The diff coverage is 98.41%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2450   +/-   ##
=========================================
  Coverage     79.93%   79.93%           
- Complexity     1408     1415    +7     
=========================================
  Files          1548     1549    +1     
  Lines         41338    41400   +62     
  Branches       3452     3453    +1     
=========================================
+ Hits          33043    33094   +51     
- Misses         6815     6824    +9     
- Partials       1480     1482    +2     
Impacted Files Coverage Δ
...e/servicecomb/swagger/extend/ModelResolverExt.java 93.67% <80.00%> (+0.33%) ⬆️
...mb/demo/pojo/client/TestNotRecommendedService.java 100.00% <100.00%> (ø)
.../servicecomb/registry/discovery/DiscoveryTree.java 96.49% <0.00%> (-3.51%) ⬇️
...mb/serviceregistry/client/http/RestClientUtil.java 75.70% <0.00%> (-1.87%) ⬇️
...he/servicecomb/foundation/common/net/NetUtils.java 62.99% <0.00%> (-1.58%) ⬇️
...egistry/client/http/ServiceRegistryClientImpl.java 68.85% <0.00%> (-1.17%) ⬇️
...ache/servicecomb/foundation/common/net/IpPort.java 86.66% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a063df5...7ef614f. Read the comment docs.

@liubao68 liubao68 merged commit 6be3c5e into apache:master Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants