Skip to content

[#SCB-2271]refactoring router code#2500

Merged
liubao68 merged 2 commits intoapache:masterfrom
liubao68:darklaunch
Aug 12, 2021
Merged

[#SCB-2271]refactoring router code#2500
liubao68 merged 2 commits intoapache:masterfrom
liubao68:darklaunch

Conversation

@liubao68
Copy link
Copy Markdown
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #2500 (9b336a4) into master (540e1e3) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

❗ Current head 9b336a4 differs from pull request most recent head 7aedcfb. Consider uploading reports for the commit 7aedcfb to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2500      +/-   ##
============================================
- Coverage     79.19%   79.19%   -0.01%     
  Complexity     1419     1419              
============================================
  Files          1559     1559              
  Lines         41567    41572       +5     
  Branches       3469     3470       +1     
============================================
+ Hits          32920    32923       +3     
- Misses         7156     7158       +2     
  Partials       1491     1491              
Impacted Files Coverage Δ
...omb/registry/api/registry/MicroserviceFactory.java 67.56% <ø> (ø)
...icecomb/registry/consumer/MicroserviceVersion.java 100.00% <ø> (ø)
.../registry/consumer/StaticMicroserviceVersions.java 100.00% <ø> (ø)
...ache/servicecomb/registry/version/VersionRule.java 83.33% <ø> (ø)
...ecomb/registry/version/VersionRuleFixedParser.java 100.00% <ø> (ø)
...comb/registry/version/VersionRuleLatestParser.java 100.00% <ø> (ø)
...ecomb/registry/version/VersionRuleRangeParser.java 100.00% <ø> (ø)
...b/registry/version/VersionRuleStartFromParser.java 100.00% <ø> (ø)
...che/servicecomb/registry/version/VersionUtils.java 75.00% <ø> (ø)
.../router/exception/RouterIllegalParamException.java 0.00% <ø> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 540e1e3...7aedcfb. Read the comment docs.

@liubao68 liubao68 merged commit bb49ed3 into apache:master Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants