Skip to content

[SCB-2331] swagger generator support NotBlank and NotEmpty annotations#2554

Merged
liubao68 merged 2 commits intoapache:masterfrom
fanjiwang1992:fjw-cse01
Sep 7, 2021
Merged

[SCB-2331] swagger generator support NotBlank and NotEmpty annotations#2554
liubao68 merged 2 commits intoapache:masterfrom
fanjiwang1992:fjw-cse01

Conversation

@fanjiwang1992
Copy link
Copy Markdown
Member

Current swagger version is 1.6.2, this version do not recognize NotBlank and NotEmpty annotations. In some cases, it is misunderstand that some fields Using NotBlank and NotEmpty annotations are not equired.

fanjiwang and others added 2 commits September 7, 2021 07:02
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 7, 2021

Codecov Report

Merging #2554 (96d6a2a) into master (cda08df) will increase coverage by 0.01%.
The diff coverage is 90.47%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2554      +/-   ##
============================================
+ Coverage     77.63%   77.64%   +0.01%     
  Complexity     1420     1420              
============================================
  Files          1597     1597              
  Lines         42444    42464      +20     
  Branches       3575     3578       +3     
============================================
+ Hits          32951    32971      +20     
  Misses         7999     7999              
  Partials       1494     1494              
Impacted Files Coverage Δ
...ger/generator/core/AbstractOperationGenerator.java 88.84% <90.00%> (+0.10%) ⬆️
...xrs/client/validation/ValidationServiceClient.java 75.60% <100.00%> (ø)
...ache/servicecomb/foundation/common/net/IpPort.java 86.66% <0.00%> (+3.33%) ⬆️
...r/springmvc/reference/CseHttpMessageConverter.java 64.70% <0.00%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cda08df...96d6a2a. Read the comment docs.

@liubao68 liubao68 merged commit 68e5228 into apache:master Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants