Skip to content

[SCB-2318]revert PR[#2350] and add test case for map null value#2580

Merged
liubao68 merged 2 commits intoapache:masterfrom
liubao68:master
Sep 16, 2021
Merged

[SCB-2318]revert PR[#2350] and add test case for map null value#2580
liubao68 merged 2 commits intoapache:masterfrom
liubao68:master

Conversation

@liubao68
Copy link
Copy Markdown
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #2580 (503981a) into master (fff8c3e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2580   +/-   ##
=========================================
  Coverage     77.67%   77.68%           
  Complexity     1427     1427           
=========================================
  Files          1598     1598           
  Lines         42574    42576    +2     
  Branches       3588     3585    -3     
=========================================
+ Hits          33071    33074    +3     
+ Misses         8003     8001    -2     
- Partials       1500     1501    +1     
Impacted Files Coverage Δ
...pache/servicecomb/demo/pojo/client/PojoClient.java 82.60% <ø> (-0.28%) ⬇️
...vicecomb/demo/pojo/client/CodeFirstPojoClient.java 97.77% <100.00%> (+0.34%) ⬆️
...n/java/org/apache/servicecomb/AuthHandlerBoot.java 100.00% <100.00%> (+20.00%) ⬆️
...icecomb/authentication/RSAAuthenticationToken.java 100.00% <100.00%> (+6.45%) ⬆️
...thentication/provider/RSAProviderTokenManager.java 78.37% <100.00%> (+5.65%) ⬆️
...ervicecomb/foundation/vertx/stream/PumpCommon.java 70.37% <0.00%> (-7.41%) ⬇️
...b/core/invocation/timeout/PassingTimeStrategy.java 94.44% <0.00%> (-5.56%) ⬇️
.../servicecomb/registry/discovery/DiscoveryTree.java 96.49% <0.00%> (-3.51%) ⬇️
...cecomb/registry/consumer/MicroserviceVersions.java 87.39% <0.00%> (-1.69%) ⬇️
...egistry/client/http/ServiceRegistryClientImpl.java 70.88% <0.00%> (-0.39%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fff8c3e...503981a. Read the comment docs.

@liubao68 liubao68 merged commit b1948e1 into apache:master Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants