Skip to content

[SCB-2343]fix highway empty string serialization problem#2597

Merged
liubao68 merged 1 commit intoapache:masterfrom
liubao68:timing
Sep 25, 2021
Merged

[SCB-2343]fix highway empty string serialization problem#2597
liubao68 merged 1 commit intoapache:masterfrom
liubao68:timing

Conversation

@liubao68
Copy link
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #2597 (761695f) into master (ad0dc90) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2597      +/-   ##
============================================
+ Coverage     77.69%   77.72%   +0.02%     
- Complexity     1428     1429       +1     
============================================
  Files          1598     1598              
  Lines         42626    42652      +26     
  Branches       3591     3591              
============================================
+ Hits          33119    33150      +31     
+ Misses         8006     8000       -6     
- Partials       1501     1502       +1     
Impacted Files Coverage Δ
...vicecomb/demo/pojo/client/CodeFirstPojoClient.java 98.31% <100.00%> (+0.22%) ⬆️
...pache/servicecomb/demo/pojo/client/PojoClient.java 82.60% <100.00%> (ø)
...ringmvc/client/CodeFirstRestTemplateSpringmvc.java 96.02% <100.00%> (+0.16%) ⬆️
.../src/main/java/io/protostuff/ProtobufOutputEx.java 79.94% <100.00%> (-0.06%) ⬇️
.../servicecomb/registry/discovery/DiscoveryTree.java 96.49% <0.00%> (-3.51%) ⬇️
...ecomb/provider/pojo/PojoConsumerMetaRefresher.java 75.60% <0.00%> (-2.44%) ⬇️
...egistry/client/http/ServiceRegistryClientImpl.java 71.26% <0.00%> (+1.14%) ⬆️
...mb/serviceregistry/client/http/RestClientUtil.java 80.55% <0.00%> (+1.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad0dc90...761695f. Read the comment docs.

@liubao68 liubao68 merged commit 3286fa4 into apache:master Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants