[SCB-2387] optimize abnormal print information of SwaggerProducerOper…#2722
[SCB-2387] optimize abnormal print information of SwaggerProducerOper…#2722david6969xin wants to merge 2 commits intoapache:1.3.xfrom david6969xin:branch_1.3.x_2387
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.3.x #2722 +/- ##
=========================================
Coverage 82.99% 83.00%
Complexity 746 746
=========================================
Files 1233 1233
Lines 33082 33082
Branches 3001 3001
=========================================
+ Hits 27458 27461 +3
+ Misses 4438 4437 -1
+ Partials 1186 1184 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if (shouldPrintErrorLog(e)) { | ||
| LOGGER.error("unexpected error operation={}, message={}", | ||
| invocation.getInvocationQualifiedName(), ExceptionUtils.getExceptionMessageWithoutTrace(e)); | ||
| invocation.getInvocationQualifiedName(), e.getMessage()); |
There was a problem hiding this comment.
Why modify this ? There is no SCB-2387 for this.
There was a problem hiding this comment.
There was a problem hiding this comment.
Not all of the sensitive contents can be blocked by this way. For example, the Jackson may put raw JSON string into exception message.
There was a problem hiding this comment.
Personally I'd prefer not modify this. This is not an actual serious information leak problem. And if the user's do need fix it, they can add try-catch block to avoid throw JsonParseException.
This information is quite useful for problem analysis and have modified many times.
|
不处理 |
4 participants
…ation
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean install -Pitto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.