Skip to content

[SCB-2385]fix IsolationDiscoveryFilter create many temporary objects#2731

Merged
liubao68 merged 2 commits intoapache:1.3.xfrom
lbc97:1.3.x
Mar 4, 2022
Merged

[SCB-2385]fix IsolationDiscoveryFilter create many temporary objects#2731
liubao68 merged 2 commits intoapache:1.3.xfrom
lbc97:1.3.x

Conversation

@lbc97
Copy link
Copy Markdown
Contributor

@lbc97 lbc97 commented Mar 4, 2022

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #2731 (f87ee25) into 1.3.x (ad53a38) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head f87ee25 differs from pull request most recent head b075707. Consider uploading reports for the commit b075707 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##              1.3.x    #2731      +/-   ##
============================================
- Coverage     82.99%   82.99%   -0.01%     
  Complexity      746      746              
============================================
  Files          1233     1233              
  Lines         33082    33081       -1     
  Branches       3001     3001              
============================================
- Hits          27458    27457       -1     
  Misses         4438     4438              
  Partials       1186     1186              
Impacted Files Coverage Δ
...b/loadbalance/filter/IsolationDiscoveryFilter.java 87.01% <100.00%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad53a38...b075707. Read the comment docs.

@liubao68 liubao68 merged commit d3fd70c into apache:1.3.x Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants