[#2795]Fixed the issue that the dynamic modification configuration of gray release is invalid. #2799
Merged
liubao68 merged 2 commits intoapache:masterfrom Apr 26, 2022
Merged
Conversation
The new constructor makes the original constructor invalid.
hezhangjian
reviewed
Apr 25, 2022
| public RouterRuleCache(Environment environment) { | ||
| representer.getPropertyUtils().setSkipMissingProperties(true); | ||
| GovernanceEventManager.register(this); | ||
| this.environment = environment; |
Member
There was a problem hiding this comment.
maybe we should put this line to the first line of consturctor
hezhangjian
reviewed
Apr 25, 2022
|
|
||
| public RouterRuleCache() { | ||
| @Autowired | ||
| public RouterRuleCache(Environment environment) { |
Member
There was a problem hiding this comment.
can we mark environment final?
hezhangjian
approved these changes
Apr 25, 2022
liubao68
approved these changes
Apr 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new constructor makes the original constructor invalid.Combine the two constructors so that the class is loaded correctly.