[SCB-2467] use standard Integer#compareTo(···) method#2804
Merged
liubao68 merged 1 commit intoapache:masterfrom Apr 27, 2022
Merged
[SCB-2467] use standard Integer#compareTo(···) method#2804liubao68 merged 1 commit intoapache:masterfrom
liubao68 merged 1 commit intoapache:masterfrom
Conversation
Member
|
@david6969xin this is a bug fix or improvment? |
Codecov Report
@@ Coverage Diff @@
## master #2804 +/- ##
=========================================
Coverage 77.30% 77.30%
Complexity 1418 1418
=========================================
Files 1616 1616
Lines 43315 43313 -2
Branches 3667 3666 -1
=========================================
+ Hits 33483 33484 +1
+ Misses 8297 8296 -1
+ Partials 1535 1533 -2
Continue to review full report at Codecov.
|
Contributor
Author
|
Member
|
@david6969xin I would suggest replace all pattern of this. |
Contributor
Author
|
@shoothzj only one that satisfies this pattern |
hezhangjian
approved these changes
Apr 27, 2022
liubao68
approved these changes
Apr 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean install -Pitto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.