Skip to content

[SCB-2467] use standard Integer#compareTo(···) method#2804

Merged
liubao68 merged 1 commit intoapache:masterfrom
david6969xin:branch_2467
Apr 27, 2022
Merged

[SCB-2467] use standard Integer#compareTo(···) method#2804
liubao68 merged 1 commit intoapache:masterfrom
david6969xin:branch_2467

Conversation

@david6969xin
Copy link
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@hezhangjian
Copy link
Member

hezhangjian commented Apr 27, 2022

@david6969xin this is a bug fix or improvment?

@codecov-commenter
Copy link

Codecov Report

Merging #2804 (6dee387) into master (7faf4bc) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master    #2804   +/-   ##
=========================================
  Coverage     77.30%   77.30%           
  Complexity     1418     1418           
=========================================
  Files          1616     1616           
  Lines         43315    43313    -2     
  Branches       3667     3666    -1     
=========================================
+ Hits          33483    33484    +1     
+ Misses         8297     8296    -1     
+ Partials       1535     1533    -2     
Impacted Files Coverage Δ
...org/apache/servicecomb/router/model/RouteItem.java 57.14% <0.00%> (+3.80%) ⬆️
...mb/config/ConfigCenterConfigurationSourceImpl.java 9.78% <0.00%> (-1.09%) ⬇️
.../servicecomb/registry/discovery/DiscoveryTree.java 100.00% <0.00%> (+3.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7faf4bc...6dee387. Read the comment docs.

@david6969xin
Copy link
Contributor Author

@david6969xin this is a bug fix or improvment?
improvment

@hezhangjian
Copy link
Member

@david6969xin I would suggest replace all pattern of this.
cc @liubao68

@david6969xin
Copy link
Contributor Author

@shoothzj only one that satisfies this pattern

@liubao68 liubao68 merged commit 46afa38 into apache:master Apr 27, 2022
@david6969xin david6969xin deleted the branch_2467 branch May 13, 2022 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants