[SCB-2529] enable checkstyle NewlineAtEndOfFile

ci/checkstyle/checkstyle.xml

@@ -26,6 +26,8 @@
     Description: none
 -->
 <module name="Checker">
+  <module name="NewlineAtEndOfFile">
+  </module>
   <module name="TreeWalker">
     <module name="AvoidStarImport"/>
     <module name="RedundantImport"/>

clients/config-center-client/src/main/java/org/apache/servicecomb/config/center/client/AddressManager.java

@@ -43,4 +43,4 @@ protected String normalizeUri(String endpoint) {
   public void onRefreshEndpointEvent(RefreshEndpointEvent event) {
     refreshEndpoint(event, RefreshEndpointEvent.CONFIG_CENTER_NAME);
   }
-}
+}

clients/http-client-common/src/main/java/org/apache/servicecomb/http/client/common/HttpTransportImpl.java

@@ -107,4 +107,4 @@ private static SignRequest createSignRequest() {
   public void addHeaders(Map<String, String> headers) {
     this.globalHeaders = headers;
   }
-}
+}

clients/service-center-client/src/main/java/org/apache/servicecomb/service/center/client/model/SchemaInfo.java

@@ -57,4 +57,4 @@ public String getSummary() {
   public void setSummary(String summary) {
     this.summary = summary;
   }
-}
+}

common/common-access-log/src/test/java/org/apache/servicecomb/common/accessLog/core/element/impl/InvocationContextItemTest.java

@@ -148,4 +148,4 @@ public void clientGetFormattedItemOnInvocationNotFound() {
     ITEM.appendClientFormattedItem(finishEvent, strBuilder);
     MatcherAssert.assertThat(strBuilder.toString(), Matchers.is(InvocationContextAccessItem.NOT_FOUND));
   }
-}
+}

common/common-protobuf/src/main/java/org/apache/servicecomb/codec/protobuf/internal/converter/SwaggerToProtoGenerator.java

@@ -242,7 +242,7 @@ private void wrapPropertyToMessage(String protoName, Object property) {
   private String tryFindEnumType(List<String> enums) {
     if (enums != null && !enums.isEmpty()) {
       String strEnums = enums.toString();
-      String enumName = "Enum_" + Hashing.sha256().hashString(strEnums, StandardCharsets.UTF_8).toString();
+      String enumName = "Enum_" + Hashing.sha256().hashString(strEnums, StandardCharsets.UTF_8);
       pending.add(() -> createEnum(enumName, enums));
       return enumName;
     }

common/common-protobuf/src/test/java/io/protostuff/runtime/model/ModelProtobuf.java

@@ -2167,8 +2167,8 @@ public Builder setOperationNameBytes(
       }
       private com.google.protobuf.MapField<java.lang.String, java.lang.String>
       internalGetMutableCseContext() {
-        onChanged();;
-        if (cseContext_ == null) {
+        onChanged();
+          if (cseContext_ == null) {
           cseContext_ = com.google.protobuf.MapField.newMapField(
               CseContextDefaultEntryHolder.defaultEntry);
         }
@@ -2298,8 +2298,8 @@ public Builder putAllCseContext(
       }
       private com.google.protobuf.MapField<java.lang.String, io.protostuff.runtime.model.ModelProtobuf.User>
       internalGetMutableUserMap() {
-        onChanged();;
-        if (userMap_ == null) {
+        onChanged();
+          if (userMap_ == null) {
           userMap_ = com.google.protobuf.MapField.newMapField(
               UserMapDefaultEntryHolder.defaultEntry);
         }

common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/param/RestClientRequestImpl.java

@@ -134,7 +134,7 @@ public Future<Void> end() {
   protected Future<Void> doEndWithUpload() {
     request.setChunked(true);
 
-    String boundary = "boundary" + UUID.randomUUID().toString();
+    String boundary = "boundary" + UUID.randomUUID();
     putHeader(CONTENT_TYPE, MULTIPART_FORM_DATA + "; charset=UTF-8; boundary=" + boundary);
 
     return genBodyForm(boundary).onSuccess(v -> attachFiles(boundary)).onFailure(e -> asyncResp.consumerFail(e));

common/common-rest/src/test/java/org/apache/servicecomb/common/rest/RestProducerInvocationCreatorTest.java

@@ -181,4 +181,4 @@ public void should_merge_invocation_context_from_request() {
 
     assertThat(invocation.getContext("k")).isEqualTo("v");
   }
-}
+}

common/common-rest/src/test/java/org/apache/servicecomb/common/rest/VertxRestInvocationTest.java

@@ -54,4 +54,4 @@ void createInvocation() {
 
     Mockito.verify(routingContext, Mockito.times(1)).put(RestConst.REST_INVOCATION_CONTEXT, invocation);
   }
-}
+}

common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/query/QueryCodecCsvTest.java

@@ -114,4 +114,4 @@ void should_decode_values_start_with_delimiter() {
       should_decode(",,1", new int[] {0, 0, 1});
     }
   }
-}
+}

common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/query/QueryCodecMultiTest.java

@@ -104,4 +104,4 @@ void should_decode_null_to_single() {
       should_decode((String) null, null);
     }
   }
-}
+}

common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/query/QueryCodecPipesTest.java

@@ -114,4 +114,4 @@ void should_decode_values_start_with_delimiter() {
       should_decode("||1", new int[] {0, 0, 1});
     }
   }
-}
+}

common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/query/QueryCodecSsvTest.java

@@ -114,4 +114,4 @@ void should_decode_values_start_with_delimiter() {
       should_decode("  1", new int[] {0, 0, 1});
     }
   }
-}
+}

common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/query/QueryCodecTsvTest.java

@@ -114,4 +114,4 @@ void should_decode_values_start_with_delimiter() {
       should_decode("\t\t1", new int[] {0, 0, 1});
     }
   }
-}
+}

common/common-rest/src/test/java/org/apache/servicecomb/common/rest/codec/query/QueryCodecsTest.java

@@ -40,4 +40,4 @@ void can_override_by_customize_implement() {
     assertThat(queryCodecs.find(QueryCodecCsv.CODEC_NAME).getClass())
         .isEqualTo(MyQueryCodecCsv.class);
   }
-}
+}

common/common-rest/src/test/java/org/apache/servicecomb/common/rest/definition/path/PathVarParamWriterTest.java

@@ -93,4 +93,4 @@ public String getParamName(){
     }.getMockInstance();
     return new PathVarParamWriter(restParam);
   }
-}
+}

common/common-rest/src/test/java/org/apache/servicecomb/common/rest/definition/path/URLPathStringBuilderTest.java

@@ -50,4 +50,4 @@ public void appendQuery() {
     builder.appendQuery("gh", "jk");
     Assertions.assertEquals("?ab=cd&ef=&gh=jk", builder.build());
   }
-}
+}

common/common-rest/src/test/java/org/apache/servicecomb/common/rest/filter/inner/RestServerCodecFilterTest.java

@@ -218,4 +218,4 @@ public void should_not_encode_transfer_encoding_header() throws ExecutionExcepti
       }
     };
   }
-}
+}

core/src/main/java/org/apache/servicecomb/core/event/InvocationHandlersStartEvent.java

@@ -23,4 +23,4 @@ public class InvocationHandlersStartEvent extends InvocationBaseEvent {
   public InvocationHandlersStartEvent(Invocation invocation) {
     super(invocation);
   }
-}
+}

core/src/main/java/org/apache/servicecomb/core/event/InvocationStartSendRequestEvent.java

@@ -23,4 +23,4 @@ public class InvocationStartSendRequestEvent extends InvocationBaseEvent {
   public InvocationStartSendRequestEvent(Invocation invocation) {
     super(invocation);
   }
-}
+}

core/src/main/java/org/apache/servicecomb/core/event/InvocationTimeoutCheckEvent.java

@@ -23,4 +23,4 @@ public class InvocationTimeoutCheckEvent extends InvocationBaseEvent {
   public InvocationTimeoutCheckEvent(Invocation invocation) {
     super(invocation);
   }
-}
+}

core/src/main/java/org/apache/servicecomb/core/filter/impl/JacksonPropertyNodeNameProvider.java

@@ -54,4 +54,4 @@ private String getJavaBeanPropertyName(JavaBeanProperty property) {
         .findFirst()
         .orElse(property.getName());
   }
-}
+}

core/src/main/java/org/apache/servicecomb/core/filter/impl/ParameterValidatorFilter.java

@@ -90,7 +90,7 @@ private boolean useResourceBundleMessageInterpolator() {
   public CompletableFuture<Response> onFilter(Invocation invocation, FilterNode nextNode) {
     Set<ConstraintViolation<Object>> violations = doValidate(invocation);
     if (violations.size() > 0) {
-      LOGGER.error("Parameter validation failed : " + violations.toString());
+      LOGGER.error("Parameter validation failed : " + violations);
       return AsyncUtils.completeExceptionally(new ConstraintViolationException(violations));
     }
 

core/src/main/java/org/apache/servicecomb/core/invocation/endpoint/EndpointCacheUtils.java

@@ -44,4 +44,4 @@ public static Endpoint getOrCreate(String uri) {
   public static Endpoint create(String uri) {
     return EndpointUtils.parse(EndpointUtils.formatFromUri(uri));
   }
-}
+}

core/src/main/java/org/apache/servicecomb/core/invocation/endpoint/EndpointUtils.java

@@ -135,7 +135,7 @@ private static String extractHostFromPath(URIBuilder builder) {
     if (path.startsWith("/")) {
       path = path.substring(1);
     }
-    if (path.indexOf("/") != -1) {
+    if (path.contains("/")) {
       path = path.substring(0, path.indexOf("/"));
     }
     return path;

core/src/main/java/org/apache/servicecomb/core/provider/producer/ProducerProviderManager.java

@@ -130,4 +130,4 @@ private void registerUrlPrefixToSwagger(Swagger swagger) {
       swagger.setBasePath(urlPrefix + swagger.getBasePath());
     }
   }
-}
+}

core/src/test/java/org/apache/servicecomb/core/definition/OperationConfigTest.java

@@ -68,4 +68,4 @@ void should_get_invocation_timeout_value() {
       assertThat(config.getMsInvocationTimeout()).isEqualTo(1);
     }
   }
-}
+}

core/src/test/java/org/apache/servicecomb/core/exception/ExceptionsTest.java

@@ -106,4 +106,4 @@ void should_protect_when_converter_throw_exception() {
               + "converter exception:org.apache.servicecomb.foundation.test.scaffolding.exception.RuntimeExceptionWithoutStackTrace: mock exception when convert\n");
     }
   }
-}
+}

core/src/test/java/org/apache/servicecomb/core/exception/converter/TimeoutExceptionConverterTest.java

@@ -55,4 +55,4 @@ void should_log_detail() {
               "Request timeout, Details: The timeout period of 30000ms has been exceeded while executing GET /xxx for server 1.1.1.1:8080.");
     }
   }
-}
+}

core/src/test/java/org/apache/servicecomb/core/filter/FilterChainTest.java

@@ -216,4 +216,4 @@ private void checkHighwayChain(Transport transport, FilterNode chain)
         .get();
     assertThat(msg).containsExactly("main", THREAD_NAME, THREAD_NAME);
   }
-}
+}

core/src/test/java/org/apache/servicecomb/core/filter/impl/ParameterValidatorFilterTest.java

@@ -171,4 +171,4 @@ public void should_include_all_validate_detail() {
     assertThat(details.stream().map(ValidateDetail::getMessage))
         .contains("not null", "can not be null", "can not be blank");
   }
-}
+}

core/src/test/java/org/apache/servicecomb/core/filter/impl/ProducerOperationFilterTest.java

@@ -201,4 +201,4 @@ public void should_unify_IllegalArgumentException_message_when_convert_exception
     CommonExceptionData data = (CommonExceptionData) throwable.getErrorData();
     assertThat(data.getMessage()).isEqualTo("Parameters not valid or types not match.");
   }
-}
+}

core/src/test/java/org/apache/servicecomb/core/filter/impl/SimpleLoadBalanceFilterTest.java

@@ -73,4 +73,4 @@ public void should_invoke_next_directly_when_invocation_already_has_endpoint()
       }
     };
   }
-}
+}

core/src/test/java/org/apache/servicecomb/core/invocation/ProducerInvocationFlowTest.java

@@ -156,4 +156,4 @@ public void should_finish_invocation_when_invocation_fail() {
       }
     };
   }
-}
+}

core/src/test/java/org/apache/servicecomb/core/invocation/endpoint/EndpointTest.java

@@ -93,4 +93,4 @@ void should_set_endpoint_to_invocation_when_map_arguments() {
 
     assertThat(holder.value).isSameAs(endpoint);
   }
-}
+}

core/src/test/java/org/apache/servicecomb/core/invocation/endpoint/EndpointUtilsTest.java

@@ -117,4 +117,4 @@ void should_not_change() {
       assertThat(formatFromUri("abc://host:123?q1=v1")).isEqualTo("abc://host:123?q1=v1");
     }
   }
-}
+}

core/src/test/java/org/apache/servicecomb/core/invocation/timeout/PassingTimeStrategyTest.java

@@ -75,4 +75,4 @@ void should_calc_elapsed_time_as_passing_time() {
 
     assertThat(elapsedNanoTime).isEqualTo(TimeUnit.MILLISECONDS.toNanos(90));
   }
-}
+}

core/src/test/java/org/apache/servicecomb/core/invocation/timeout/ProcessingTimeStrategyTest.java

@@ -86,4 +86,4 @@ public void checkTimeout(Invocation invocation) {
 
     assertThat(invocation.getContext(CHAIN_PROCESSING)).isEqualTo("60");
   }
-}
+}

demo/demo-edge/consumer/src/main/java/org/apache/servicecomb/demo/edge/consumer/Consumer.java

@@ -141,7 +141,7 @@ public void testEncrypt() {
 
     String expected = "{name=userName, age=10, userId=serviceTokenTest-userId, body1=b1, body2=b2, body3=b3}";
     Assert.isTrue(expected.equalsIgnoreCase(result.toString()),
-        String.format("expected: %s\nreal    : %s", expected, result.toString()));
+        String.format("expected: %s\nreal    : %s", expected, result));
   }
 
   protected void testRecursiveSelf() {
@@ -227,7 +227,7 @@ protected void testDownloadBigFile() {
       }
       return null;
     });
-    Assert.isTrue(size.get() == 10 * 1024 * 1024, "size is : " + String.valueOf(size.get()) + " not 10 * 1024 * 1024");
+    Assert.isTrue(size.get() == 10 * 1024 * 1024, "size is : " + size.get() + " not 10 * 1024 * 1024");
     System.out.println("test download bigFile finished");
   }
 

demo/demo-edge/edge-service/src/main/java/org/apache/servicecomb/demo/edge/service/encrypt/filter/EdgeSignatureRequestFilter.java

@@ -60,7 +60,7 @@ public Response afterReceiveRequest(Invocation invocation, HttpServletRequestEx
       hasher.putString(name, StandardCharsets.UTF_8);
       hasher.putString(requestEx.getParameter(name), StandardCharsets.UTF_8);
     }
-    LOGGER.info("afterReceiveRequest signature: {}", hasher.hash().toString());
+    LOGGER.info("afterReceiveRequest signature: {}", hasher.hash());
 
     return null;
   }

demo/demo-edge/edge-service/src/main/resources/config/log4j.properties

@@ -16,4 +16,4 @@
 #
 
 log4j.rootLogger=INFO,stdout
-log4j.appender.stdout.layout.ConversionPattern=[%d{yyyy-MM-dd HH:mm:ss,SSS/zzz}][%t][%p]%m %l%n
+log4j.appender.stdout.layout.ConversionPattern=[%d{yyyy-MM-dd HH:mm:ss,SSS/zzz}][%t][%p]%m %l%n

demo/demo-jaxrs/jaxrs-server/src/main/java/org/apache/servicecomb/demo/jaxrs/server/QueryParamWithListSchema.java

@@ -33,30 +33,30 @@ public class QueryParamWithListSchema {
   @Path("queryListCSV")
   @GET
   public String queryListCSV(@ApiParam(collectionFormat = "csv") @QueryParam("queryList") List<String> queryList) {
-    return queryList == null ? "null" : queryList.size() + ":" + queryList.toString();
+    return queryList == null ? "null" : queryList.size() + ":" + queryList;
   }
 
   @Path("queryListSSV")
   @GET
   public String queryListSSV(@ApiParam(collectionFormat = "ssv") @QueryParam("queryList") List<String> queryList) {
-    return queryList == null ? "null" : queryList.size() + ":" + queryList.toString();
+    return queryList == null ? "null" : queryList.size() + ":" + queryList;
   }
 
   @Path("queryListTSV")
   @GET
   public String queryListTSV(@ApiParam(collectionFormat = "tsv") @QueryParam("queryList") List<String> queryList) {
-    return queryList == null ? "null" : queryList.size() + ":" + queryList.toString();
+    return queryList == null ? "null" : queryList.size() + ":" + queryList;
   }
 
   @Path("queryListPIPES")
   @GET
   public String queryListPIPES(@ApiParam(collectionFormat = "pipes") @QueryParam("queryList") List<String> queryList) {
-    return queryList == null ? "null" : queryList.size() + ":" + queryList.toString();
+    return queryList == null ? "null" : queryList.size() + ":" + queryList;
   }
 
   @Path("queryListMULTI")
   @GET
   public String queryListMULTI(@ApiParam(collectionFormat = "multi") @QueryParam("queryList") List<String> queryList) {
-    return queryList == null ? "null" : queryList.size() + ":" + queryList.toString();
+    return queryList == null ? "null" : queryList.size() + ":" + queryList;
   }
 }

demo/demo-jaxrs/jaxrs-server/src/main/java/org/apache/servicecomb/demo/jaxrs/server/SchemeInterfaceJaxrsImpl.java

@@ -32,7 +32,7 @@ public int reduce(int a, int b) {
   }
 
   public int add(String a, String b) {
-    return Integer.valueOf(a) + Integer.valueOf(b);
+    return Integer.parseInt(a) + Integer.parseInt(b);
   }
 
   @Override

demo/demo-multi-service-center/demo-multi-service-center-client/src/main/java/org/apache/servicecomb/demo/multiServiceCenterClient/ServerBTest.java

@@ -64,4 +64,4 @@ public void testRestTransport() throws Exception {
   public String getMicroserviceName() {
     return "demo-multi-service-center-serverB";
   }
-}
+}

demo/demo-multi-service-center/demo-multi-service-center-serverB/src/main/resources/application.properties

@@ -17,4 +17,4 @@
 
 demo.multi.service.center.serverB.actual.key6=key6
 demo.multi.service.center.serverB.actual.key7.1=key71
-demo.multi.service.center.serverB.actual.key7.2=key72
+demo.multi.service.center.serverB.actual.key7.2=key72

demo/demo-pojo/pojo-client/src/main/java/org/apache/servicecomb/demo/pojo/client/invoker/ClientModel.java

@@ -36,4 +36,4 @@ public int getCode() {
   public void setCode(int code) {
     this.code = code;
   }
-}
+}