[SCB-2589] fix spans is null sometimes#3104
Merged
hezhangjian merged 2 commits intoapache:masterfrom Jun 21, 2022
Merged
Conversation
hezhangjian
requested changes
Jun 21, 2022
| List<Span> spans = zipkin.getTrace(traceId(loggedIds)); | ||
| List<Span> spans; | ||
| do { | ||
| spans = zipkin.getTrace(traceId(loggedIds)); |
Member
There was a problem hiding this comment.
we need to sleep in case of cpu 100%, also we need a reasonable timeout.
Howerver, instead of write our impl, we can use https://github.com/awaitility/awaitility library
Awaitility.await().atMost(10, SECONDS).until(() -> xxxxxx);
Contributor
Author
There was a problem hiding this comment.
just testing code, that almost never happens, don't need to think so much. of course, it's better to be strict !
Codecov Report
@@ Coverage Diff @@
## master #3104 +/- ##
=========================================
Coverage 77.49% 77.50%
Complexity 1431 1431
=========================================
Files 1612 1612
Lines 43268 43268
Branches 3645 3645
=========================================
+ Hits 33532 33534 +2
+ Misses 8233 8232 -1
+ Partials 1503 1502 -1
Continue to review full report at Codecov.
|
hezhangjian
approved these changes
Jun 21, 2022
Member
|
Great work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean install -Pitto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.