[SCB-2665]Add the load balance governance by lbc97 · Pull Request #3267 · apache/servicecomb-java-chassis

lbc97 · 2022-08-05T10:34:06Z

Follow this checklist to help us incorporate your contribution quickly and easily:

Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
Each commit in the pull request should have a meaningful subject line and body.
Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
If this contribution is large, please file an Apache Individual Contributor License Agreement.

…onfiguration item.

liubao68 · 2022-08-06T07:53:46Z

+    LoadBalanceDecorateCheckedSupplier<Object> ds = LoadBalanceDecorators.ofCheckedSupplier(()->"test");
+    GovernanceRequest request = new GovernanceRequest();
+    request.setUri("/loadrandom");
+    request.setServiceName("RandomTest");
+    LoadBalance loadBalance = loadBalanceHandler.getActuator(request);
+    Assert.assertEquals("Random",ds.withFaultInjection(loadBalance));


I think for load balance do not need this complicity.

for example

GovernanceRequest request = new GovernanceRequest(); request.setUri("/loadrandom"); request.setServiceName("RandomTest"); LoadBalance loadBalance = loadBalanceHandler.getActuator(request); Assert.assertEquals("Random",loadBalance.getRule());

This is quit enough

liubao68 · 2022-08-06T07:56:54Z

 servicecomb:
+  loadbalance:
+    rule: |
+      loadrule: Random


servicecomb: loadbalance: XXXXXXMatch: | rule: Random

Use this definition and should define matchGroup for XXXXXXMatch

liubao68 · 2022-08-06T07:57:28Z

+package org.apache.servicecomb.governance.policy;
+
+public class LoadBalancerPolicy extends AbstractPolicy {
+  private String loadrule;


change to rule

liubao68 · 2022-08-06T07:57:45Z

+    if (key.equals("rule")) {
+      return true;
+    }


delete this

liubao68 · 2022-08-06T07:58:24Z

+public abstract class AbstractLoadbalance implements LoadBalance {
+  protected String loadrule;
+
+  public AbstractLoadbalance(String loadrule) {
+    this.loadrule = loadrule;
+  }
+
+  @Override
+  public String choose() {
+    return choose(loadrule);
+  }
+


delete this class

liubao68 · 2022-08-06T07:58:46Z

+  static String decorateCheckedSupplier(LoadBalance loadBalance) {
+    return loadBalance.choose();
+  }
+
+  public String choose();
+
+  public String choose(String type);
+
+  int getOrder();
+
+  String getName();


only need one method getRule which return rule in LoadBalancePolicy

liubao68 · 2022-08-06T07:59:57Z

+public interface LoadBalanceDecorators {
+  static <T> LoadBalanceDecorateCheckedSupplier<T> ofCheckedSupplier(CheckedFunction0<T> supplier) {
+    return new LoadBalanceDecorateCheckedSupplier<>(supplier);
+  }
+
+  class LoadBalanceDecorateCheckedSupplier<T> {
+
+    private CheckedFunction0<T> supplier;
+
+    protected LoadBalanceDecorateCheckedSupplier(CheckedFunction0<T> supplier) {
+      this.supplier = supplier;
+    }
+
+    public String withFaultInjection(LoadBalance loadBalance) {
+      return LoadBalance.decorateCheckedSupplier(loadBalance);
+    }
+
+    public T get() throws Throwable {


do not need this class

liubao68 · 2022-08-06T08:00:08Z

+public class LoadBalanceUtil {
+
+  public static LoadBalance getLoadBalance(String key, LoadBalancerPolicy policy) {
+    LoadBalance loadBalance = null;
+    if (LoadBalanceConst.TYPE_RANDOM.equals(policy.getLoadrule())) {
+      loadBalance = new RandomBalancer(LoadBalanceConst.TYPE_RANDOM);
+    } else if (LoadBalanceConst.TYPE_ROUNDROBIN.equals(policy.getLoadrule())) {
+      loadBalance = new RoundRobinBalancer(LoadBalanceConst.TYPE_ROUNDROBIN);
+    }
+    return loadBalance;
+  }
+}


do not need this

liubao68 · 2022-08-06T08:00:35Z

+public class RandomBalancer extends AbstractLoadbalance implements LoadBalance{
+
+  public RandomBalancer(String loadrule) {
+    super(loadrule);
+  }
+
+  @Override
+  public String choose(String loadrule) {
+    return loadrule;
+  }
+
+  @Override
+  public int getOrder() {
+    return 100;
+  }
+
+  @Override
+  public String getName() {
+    return LoadBalanceConst.TYPE_RANDOM;
+  }
+}


do not need this

liubao68 · 2022-08-06T08:01:22Z

+
+  public RoundRobinBalancer(String loadrule) {
+    super(loadrule);
+  }
+
+  @Override
+  public String choose(String loadrule) {
+    return loadrule;
+  }
+
+  @Override
+  public int getOrder() {
+    return 100;
+  }
+
+  @Override


delete this class

liubao68 · 2022-08-06T08:03:03Z

+
+  @Override
+  protected LoadBalance createProcessor(String key, GovernanceRequest governanceRequest, LoadBalancerPolicy policy) {
+    return LoadBalanceUtil.getLoadBalance(key, policy);


return new LoadBalanceImpl()

class LoadBalanceImpl implements LoadBalance { @Override public String getRule() { return policy.getRule(); } }

liubao68 · 2022-08-06T14:03:07Z

+  @Override
+  public int getOrder() {
+    return 100;
+  }
+
+  @Override
+  public String getName() {
+    return null;
+  }


This two methods never read, why add them?

liubao68 · 2022-08-06T14:03:26Z

+package org.apache.servicecomb.loadbanlance;
+
+public class LoadBalanceImpl implements LoadBalance {
+  private String rule;


should be final

liubao68 · 2022-08-06T14:03:43Z

+  public String getRule() {
+    return rule;
+  }
+
+  public void setRule(String rule) {
+    this.rule = rule;
+  }


put methods definition after constructor

liubao68 · 2022-08-06T14:04:14Z

+public class LoadBalanceUtil {
+
+  public static LoadBalance getLoadBalance(String key, LoadBalancerPolicy policy) {
+    LoadBalance loadBalance = new LoadBalanceImpl(policy.getRule());
+    return loadBalance;
+  }
+}


delete this class and inline code

liubao68 · 2022-08-06T14:05:29Z

+  int getOrder();
+
+  String getName();


these two methods never read, why add them?

liubao68 · 2022-08-06T14:08:42Z

@@ -0,0 +1,28 @@
+package org.apache.servicecomb.loadbanlance;


add license

liubao68 · 2022-08-06T14:08:54Z

@@ -0,0 +1,43 @@
+package org.apache.servicecomb.governance;


add license

codecov-commenter · 2022-08-08T12:46:53Z

Codecov Report

Merging #3267 (507e1b4) into master (31ef85f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 507e1b4 differs from pull request most recent head e6a5b75. Consider uploading reports for the commit e6a5b75 to get more accurate results

@@             Coverage Diff              @@
##             master    #3267      +/-   ##
============================================
+ Coverage     77.44%   77.45%   +0.01%     
  Complexity     1439     1439              
============================================
  Files          1641     1646       +5     
  Lines         43575    43596      +21     
  Branches       3665     3665              
============================================
+ Hits          33746    33767      +21     
  Misses         8309     8309              
  Partials       1520     1520

Impacted Files	Coverage Δ
...ervicecomb/governance/GovernanceConfiguration.java	`100.00% <100.00%> (ø)`
...icecomb/governance/handler/LoadBalanceHandler.java	`100.00% <100.00%> (ø)`
...vicecomb/governance/policy/LoadBalancerPolicy.java	`100.00% <100.00%> (ø)`
...b/governance/properties/LoadBalanceProperties.java	`100.00% <100.00%> (ø)`
...g/apache/servicecomb/loadbanlance/LoadBalance.java	`100.00% <100.00%> (ø)`
...ache/servicecomb/loadbanlance/LoadBalanceImpl.java	`100.00% <100.00%> (ø)`
.../servicecomb/registry/discovery/DiscoveryTree.java	`96.49% <0.00%> (-3.51%)`	⬇️
...thentication/consumer/RSAConsumerTokenManager.java	`77.41% <0.00%> (+6.45%)`	⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

lbc97 force-pushed the master branch from 7b1ba12 to b3816fd Compare August 6, 2022 04:14

[SCB-2620] The long polling time is changed to be obtained from the c…

8bb6cb0

…onfiguration item.

lbc97 force-pushed the master branch from b3816fd to 23e6e5e Compare August 6, 2022 07:36

liubao68 reviewed Aug 6, 2022

View reviewed changes

lbc97 force-pushed the master branch from 23e6e5e to fc72b58 Compare August 6, 2022 10:27

liubao68 reviewed Aug 6, 2022

View reviewed changes

lbc97 force-pushed the master branch from fc72b58 to c34159d Compare August 8, 2022 09:33

add loadbalance governance

e6a5b75

lbc97 force-pushed the master branch from c34159d to e6a5b75 Compare August 8, 2022 12:16

liubao68 approved these changes Aug 8, 2022

View reviewed changes

lbc97 changed the title ~~add loadbalance governance~~ [SCB-2665]Add the load balancing function Aug 8, 2022

liubao68 changed the title ~~[SCB-2665]Add the load balancing function~~ [SCB-2665]Add the load balance governance Aug 8, 2022

liubao68 merged commit 493fcdc into apache:master Aug 8, 2022

		@@ -0,0 +1,28 @@
		package org.apache.servicecomb.loadbanlance;

Conversation

lbc97 commented Aug 5, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

liubao68 Aug 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov-commenter commented Aug 8, 2022

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

liubao68 Aug 6, 2022 •

edited

Loading