[SCB-2670] support CSE version level configuration query#3288
Merged
liubao68 merged 1 commit intoapache:masterfrom Aug 19, 2022
Merged
[SCB-2670] support CSE version level configuration query#3288liubao68 merged 1 commit intoapache:masterfrom
liubao68 merged 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3288 +/- ##
============================================
- Coverage 77.45% 77.43% -0.02%
Complexity 1449 1449
============================================
Files 1648 1648
Lines 43659 43677 +18
Branches 3674 3675 +1
============================================
+ Hits 33816 33823 +7
- Misses 8317 8329 +12
+ Partials 1526 1525 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
liubao68
reviewed
Aug 17, 2022
|
|
||
| private static final int CUSTOM_ORDER = 300; | ||
|
|
||
| private static final int INSTANCE_ORDER = 400; |
Contributor
There was a problem hiding this comment.
order should less than SERVICE_ORDER
liubao68
reviewed
Aug 17, 2022
| .setEnableCustomConfig(KieConfig.INSTANCE.enableCustomConfig()) | ||
| .setEnableLongPolling(KieConfig.INSTANCE.enableLongPolling()) | ||
| .setEnableServiceConfig(KieConfig.INSTANCE.enableServiceConfig()) | ||
| .setEnableInstanceConfig(KieConfig.INSTANCE.enableInstanceConfig()) |
Contributor
There was a problem hiding this comment.
ServiceVersionConfig is better, not instance config
lbc97
force-pushed
the
master
branch
2 times, most recently
from
1ecccc3 to
330c703
Compare
liubao68
reviewed
Aug 18, 2022
| } | ||
|
|
||
| private static ConfigurationsRequest createInstanceConfigurationsRequest(KieConfiguration configuration) { | ||
| return new ConfigurationsRequest() |
Contributor
There was a problem hiding this comment.
createVersionConfigurationsRequest
liubao68
reviewed
Aug 18, 2022
| test: | ||
| priority1: v2 | ||
| ``` | ||
| * 实例级配置：consumerIns.yaml，labels: app=demo-java-chassis-cse-v2,environment=,service=consumer,version = 0.0.1。类型为 yaml。 |
liubao68
reviewed
Aug 18, 2022
| * 执行 tests-client 里面的集成测试用例 （成功） | ||
|
|
||
| * 修改 | ||
| * 实例级配置：consumerIns.yaml。 |
liubao68
changed the title
lbc97
force-pushed
the
master
branch
2 times, most recently
from
8fc3ecf to
9090e2e
Compare
liubao68
approved these changes
Aug 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…onfiguration item.
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean install -Pitto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.