Skip to content

Bump jakarta.validation-api from 2.0.2 to 3.0.0#3335

Closed
lbc97 wants to merge 1 commit intoapache:masterfrom
lbc97:master
Closed

Bump jakarta.validation-api from 2.0.2 to 3.0.0#3335
lbc97 wants to merge 1 commit intoapache:masterfrom
lbc97:master

Conversation

@lbc97
Copy link
Copy Markdown
Contributor

@lbc97 lbc97 commented Sep 13, 2022

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Copy link
Copy Markdown
Member

@hezhangjian hezhangjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big change. Did you test it?

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #3335 (bba6a88) into master (8a28aca) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3335      +/-   ##
============================================
- Coverage     77.40%   77.37%   -0.03%     
  Complexity     1452     1452              
============================================
  Files          1648     1648              
  Lines         43714    43715       +1     
  Branches       3675     3676       +1     
============================================
- Hits          33835    33824      -11     
- Misses         8350     8360      +10     
- Partials       1529     1531       +2     
Impacted Files Coverage Δ
.../servicecomb/registry/discovery/DiscoveryTree.java 96.49% <0.00%> (-3.51%) ⬇️
...mb/serviceregistry/client/http/RestClientUtil.java 78.50% <0.00%> (-1.87%) ⬇️
...he/servicecomb/foundation/common/net/NetUtils.java 64.80% <0.00%> (-1.61%) ⬇️
...egistry/client/http/ServiceRegistryClientImpl.java 70.17% <0.00%> (-1.15%) ⬇️
.../service/center/client/ServiceCenterDiscovery.java 0.00% <0.00%> (ø)
...comb/core/definition/MicroserviceVersionsMeta.java 100.00% <0.00%> (+5.26%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lbc97
Copy link
Copy Markdown
Contributor Author

lbc97 commented Sep 13, 2022

This is a big change. Did you test it?

I have passed CI . what do you mean by test.

@hezhangjian
Copy link
Copy Markdown
Member

why do you update org.hibernate.validator:jakarta.validation-api I didn't see any usage of this

@lbc97
Copy link
Copy Markdown
Contributor Author

lbc97 commented Sep 13, 2022

why do you update org.hibernate.validator:jakarta.validation-api I didn't see any usage of this

#3320
If the customer has a requirement, upgrade it.

@hezhangjian
Copy link
Copy Markdown
Member

@lbc97 It's not in our dependency tree...

@lbc97
Copy link
Copy Markdown
Contributor Author

lbc97 commented Sep 13, 2022

@lbc97 It's not in our dependency tree...

This is just a pr. Put it up first, and then ask the team leader to review whether it fits.

@liubao68
Copy link
Copy Markdown
Contributor

If we do not use jakarta.validation-api, we do not need to add this dependencies. Users can add it themself.

@lbc97 lbc97 closed this Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants