JAV-550 support use _ to represent system environment variable config levels#348
Merged
WillemJiang merged 3 commits intoapache:masterfrom Dec 5, 2017
Merged
JAV-550 support use _ to represent system environment variable config levels#348WillemJiang merged 3 commits intoapache:masterfrom
WillemJiang merged 3 commits intoapache:masterfrom
Conversation
Member
|
@qizha Can you add an unit test for this new added feature? |
wujimin
approved these changes
Dec 5, 2017
Contributor
Author
|
sure, I just added UT for the change |
WillemJiang
changed the title
WillemJiang
changed the title
WillemJiang
approved these changes
Dec 5, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check https://servicecomb.atlassian.net/browse/jav-550 for details.. I also submit a discussion topic in google group for this issue