Skip to content

[SCB-2790]CseUriTemplateHandler implements DefaultUriBuilderFactory i…#3771

Merged
liubao68 merged 2 commits intoapache:masterfrom
liubao68:master
May 6, 2023
Merged

[SCB-2790]CseUriTemplateHandler implements DefaultUriBuilderFactory i…#3771
liubao68 merged 2 commits intoapache:masterfrom
liubao68:master

Conversation

@liubao68
Copy link
Contributor

@liubao68 liubao68 commented May 5, 2023

…nstead of deprecated api

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #3771 (ae2991c) into master (2758943) will decrease coverage by 0.03%.
The diff coverage is 92.85%.

❗ Current head ae2991c differs from pull request most recent head 7a85bbb. Consider uploading reports for the commit 7a85bbb to get more accurate results

@@             Coverage Diff              @@
##             master    #3771      +/-   ##
============================================
- Coverage     43.83%   43.81%   -0.03%     
+ Complexity     6071     6063       -8     
============================================
  Files          1555     1555              
  Lines         38249    38208      -41     
  Branches       3517     3508       -9     
============================================
- Hits          16767    16741      -26     
+ Misses        20172    20163       -9     
+ Partials       1310     1304       -6     
Impacted Files Coverage Δ
...der/springmvc/reference/CseUriTemplateHandler.java 86.66% <84.61%> (+20.49%) ⬆️
...emo/jaxrs/client/TestQueryParamWithListSchema.java 100.00% <100.00%> (ø)
...he/servicecomb/demo/springmvc/SpringmvcClient.java 82.49% <100.00%> (+0.21%) ⬆️
...ider/springmvc/reference/CseClientHttpRequest.java 65.06% <100.00%> (+0.86%) ⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@liubao68
Copy link
Contributor Author

liubao68 commented May 6, 2023

This PR will cause behavior change for 2.x users while compatible with 1.x users and spring boot default.

@liubao68 liubao68 merged commit fc76251 into apache:master May 6, 2023
liubao68 added a commit to liubao68/servicecomb-java-chassis that referenced this pull request May 6, 2023
liubao68 added a commit that referenced this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants