Skip to content

Conversation

@Sayaka617
Copy link
Contributor

(cherry picked from commit c57f5cf)

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@Sayaka617 Sayaka617 changed the title [Backport 2.8.x][#3850] Fix the problem when set content-type by ResponseEntity.header() [Backport 2.8.x][#3850] Fix the problem when setting content-type by ResponseEntity.header() does not take effect Jul 14, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3856 (37e268e) into 2.8.x (45910ef) will increase coverage by 0.01%.
The diff coverage is 81.81%.

❗ Current head 37e268e differs from pull request most recent head 5272af4. Consider uploading reports for the commit 5272af4 to get more accurate results

@@             Coverage Diff              @@
##              2.8.x    #3856      +/-   ##
============================================
+ Coverage     74.41%   74.42%   +0.01%     
- Complexity      689      690       +1     
============================================
  Files          1592     1592              
  Lines         40003    40013      +10     
  Branches       3653     3654       +1     
============================================
+ Hits          29769    29781      +12     
+ Misses         8744     8741       -3     
- Partials       1490     1491       +1     
Impacted Files Coverage Δ
...rvicecomb/foundation/vertx/http/DownloadUtils.java 71.42% <33.33%> (-7.52%) ⬇️
...comb/demo/springmvc/client/TestDownloadSchema.java 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@liubao68 liubao68 merged commit 6712e96 into apache:2.8.x Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants