Skip to content

[#3966] Add a switch to control the tracing-zipkin to adapt to the path of non CSE frameworks#3983

Merged
fanjiwang1992 merged 6 commits intoapache:masterfrom
yanghao605:master
Oct 24, 2023
Merged

[#3966] Add a switch to control the tracing-zipkin to adapt to the path of non CSE frameworks#3983
fanjiwang1992 merged 6 commits intoapache:masterfrom
yanghao605:master

Conversation

@yanghao605
Copy link
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

Merging #3983 (c0aac89) into master (ed60267) will decrease coverage by 0.54%.
Report is 5 commits behind head on master.
The diff coverage is 29.34%.

❗ Current head c0aac89 differs from pull request most recent head bb22a61. Consider uploading reports for the commit bb22a61 to get more accurate results

@@             Coverage Diff              @@
##             master    #3983      +/-   ##
============================================
- Coverage     43.99%   43.46%   -0.54%     
+ Complexity     5329     5277      -52     
============================================
  Files          1392     1390       -2     
  Lines         34041    34144     +103     
  Branches       3331     3327       -4     
============================================
- Hits          14978    14841     -137     
- Misses        17874    18119     +245     
+ Partials       1189     1184       -5     
Files Coverage Δ
...cecomb/common/rest/locator/ServicePathManager.java 58.00% <ø> (-3.82%) ⬇️
...ache/servicecomb/demo/crossapp/CrossappClient.java 90.62% <100.00%> (ø)
...pache/servicecomb/demo/edge/consumer/Consumer.java 89.04% <100.00%> (ø)
.../demo/edge/consumer/EdgeServiceGovernanceTest.java 86.76% <100.00%> (ø)
...mo/filter/tests/TestExceptionSchemaFromClient.java 75.00% <100.00%> (ø)
...b/demo/filter/tests/TestRetrySchemaFromClient.java 100.00% <100.00%> (ø)
...omb/demo/filter/tests/TestRetrySchemaFromEdge.java 100.00% <100.00%> (ø)
...org/apache/servicecomb/demo/jaxrs/JaxrsClient.java 89.36% <100.00%> (ø)
.../demo/jaxrs/client/CodeFirstRestTemplateJaxrs.java 80.95% <ø> (ø)
...demo/jaxrs/client/MultiErrorCodeServiceClient.java 85.62% <100.00%> (ø)
... and 44 more

... and 33 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yanghao605 yanghao605 requested a review from liubao68 October 23, 2023 14:10
@fanjiwang1992 fanjiwang1992 merged commit 78ddc8f into apache:master Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants