Migrate parts of metrics module to junit5#4104
Merged
hezhangjian merged 1 commit intoapache:masterfrom Dec 8, 2023
Merged
Conversation
hezhangjian
reviewed
Dec 7, 2023
| Assertions.assertEquals(0, eth0.getSend().getRate(), 0.0); | ||
| Assertions.assertEquals(8, eth0.getSend().getIndex()); | ||
| Map<String, InterfaceUsage> interfaceInfoMap = netMeter.getInterfaceUsageMap(); | ||
| Assertions.assertEquals(1, interfaceInfoMap.size()); |
Member
There was a problem hiding this comment.
plz don't change this intent
pengxiangrui127
force-pushed
the
metrics_migrate_to_junit5
branch
from
bb75eaa to
2d8b983
Compare
hezhangjian
reviewed
Dec 7, 2023
| list.add("useless"); | ||
| list.add("useless"); | ||
| list.add("eth0: 1 1 0 0 0 0 0 1 1 1 1 0 0 0 0 0"); | ||
| OsMeter osMeter = new OsMeter(meterRegistry); |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4104 +/- ##
=========================================
Coverage 44.25% 44.25%
- Complexity 5366 5367 +1
=========================================
Files 1382 1382
Lines 34255 34255
Branches 3314 3314
=========================================
+ Hits 15158 15160 +2
+ Misses 17869 17868 -1
+ Partials 1228 1227 -1 ☔ View full report in Codecov by Sentry. |
pengxiangrui127
force-pushed
the
metrics_migrate_to_junit5
branch
from
2d8b983 to
3764dc5
Compare
hezhangjian
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestDefaultLogPublisher and TestThreadPoolMetersInitializer need further analysis.