Skip to content

[SCB-2841]zone-aware filter support configure group size ratio#4107

Merged
liubao68 merged 1 commit intoapache:masterfrom
liubao68:event
Dec 8, 2023
Merged

[SCB-2841]zone-aware filter support configure group size ratio#4107
liubao68 merged 1 commit intoapache:masterfrom
liubao68:event

Conversation

@liubao68
Copy link
Copy Markdown
Contributor

@liubao68 liubao68 commented Dec 8, 2023

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 8, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (176dc2f) 44.25% compared to head (842f173) 44.29%.
Report is 1 commits behind head on master.

❗ Current head 842f173 differs from pull request most recent head c6c688e. Consider uploading reports for the commit c6c688e to get more accurate results

Files Patch % Lines
...b/loadbalance/filter/ZoneAwareDiscoveryFilter.java 72.72% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4107      +/-   ##
============================================
+ Coverage     44.25%   44.29%   +0.04%     
- Complexity     5366     5375       +9     
============================================
  Files          1382     1382              
  Lines         34255    34263       +8     
  Branches       3314     3315       +1     
============================================
+ Hits          15158    15176      +18     
+ Misses        17869    17859      -10     
  Partials       1228     1228              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liubao68 liubao68 merged commit aab6a1d into apache:master Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants