fix: shutdown nacos client when discovery destroy#4471
Merged
hezhangjian merged 1 commit intoapache:masterfrom Aug 16, 2024
Merged
fix: shutdown nacos client when discovery destroy#4471hezhangjian merged 1 commit intoapache:masterfrom
hezhangjian merged 1 commit intoapache:masterfrom
Conversation
Co-authored-by: ZhangJian He <shoothzj@gmail.com>
hezhangjian
force-pushed
the
develop-nacos-agent-destroy
branch
from
e86027e to
dfef4fa
Compare
hezhangjian
changed the title
liubao68
reviewed
Aug 19, 2024
| try { | ||
| namingService.shutDown(); | ||
| } catch (NacosException e) { | ||
| throw new IllegalStateException("destroy process is interrupted."); |
Contributor
There was a problem hiding this comment.
Do not throw exception, just add some logs and ignore. Or try catch exception in SCBEngine
liubao68
pushed a commit
that referenced
this pull request
Aug 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ISSUE #4470] Shutdown nacos client properly.