Skip to content

[SCB-415] change cluster value from "test-cluster" to "default"#610

Merged
WillemJiang merged 2 commits intoapache:masterfrom
zhengyangyong:SCB-415
Mar 19, 2018
Merged

[SCB-415] change cluster value from "test-cluster" to "default"#610
WillemJiang merged 2 commits intoapache:masterfrom
zhengyangyong:SCB-415

Conversation

@zhengyangyong
Copy link
Copy Markdown

@zhengyangyong zhengyangyong commented Mar 19, 2018

Signed-off-by: zhengyangyong yangyong.zheng@huawei.com

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
Copy link
Copy Markdown
Member

@asifdxtreme asifdxtreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

serviceName: apollo-test
env: DEV
clusters: test-cluster
clusters: default
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some explanation about this setting.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.02%) to 87.327% when pulling 2cd6b5f on zhengyangyong:SCB-415 into 8814a2e on apache:master.

@WillemJiang WillemJiang merged commit 4b5ac30 into apache:master Mar 19, 2018
@zhengyangyong zhengyangyong deleted the SCB-415 branch March 27, 2018 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants