[SCB-506]服务治理相关的需要事件上报#666
Closed
xuyiyun0929 wants to merge 3 commits into
Closed
Conversation
WillemJiang
reviewed
Apr 20, 2018
| @@ -0,0 +1,32 @@ | |||
| package org.apache.servicecomb.loadbalance.event; | |||
WillemJiang
reviewed
Apr 20, 2018
| @@ -0,0 +1,27 @@ | |||
| package org.apache.servicecomb.bizkeeper.event; | |||
WillemJiang
reviewed
Apr 20, 2018
| @@ -0,0 +1,50 @@ | |||
| package org.apache.servicecomb.bizkeeper.event; | |||
Contributor
|
You have make some related merge. Please fix it or submit a new one. |
liubao68
reviewed
Apr 24, 2018
| public enum Type { | ||
| OPEN, | ||
| CLOSE, | ||
| SUCCED, |
Contributor
There was a problem hiding this comment.
Use SUCCEDED or SUCCESSFUL. When should we use OPEN vs SUCCED?
liubao68
reviewed
Apr 24, 2018
| HystrixCircuitBreaker circuitBreaker = | ||
| HystrixCircuitBreaker.Factory.getInstance(CommandKey.toHystrixCommandKey(groupname, invocation)); | ||
| if (circuitBreaker != null && circuitBreaker.isOpen()) { | ||
| EventManager.post(new CircutBreakerEvent(invocation, this.groupname, Type.OPEN)); |
Contributor
There was a problem hiding this comment.
Format your code use code template in /etc folder and it's better to turn on show blanks in your IDE
liubao68
reviewed
Apr 24, 2018
| public static Response getFallbackResponse(String type, Throwable error, Invocation invocation) { | ||
| FallbackPolicy policy = getPolicy(type, invocation); | ||
| if (policy != null) { | ||
| EventManager.post(new FallbackEvent(policy, invocation, Type.OPEN)); |
Contributor
There was a problem hiding this comment.
Fallback is called in HystrixCommand, send event there. But I think this will send a lot of unnecessary events because any error will call fallback.
liubao68
reviewed
Apr 24, 2018
| if (circuitBreaker != null && circuitBreaker.isOpen()) { | ||
| EventManager.post(new CircutBreakerEvent(invocation, this.groupname, Type.OPEN)); | ||
| }else { | ||
| EventManager.post(new CircutBreakerEvent(invocation, this.groupname, Type.CLOSE)); |
Contributor
There was a problem hiding this comment.
We need only send event when last time is OPEN and turn to be CLOSED. Can't send for each invocation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean installto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.