Skip to content

[SCB-616] Make access log mechanism extensible#734

Merged
wujimin merged 6 commits intoapache:masterfrom
yhs0092:support_access_log_extension_dev
Jun 5, 2018
Merged

[SCB-616] Make access log mechanism extensible#734
wujimin merged 6 commits intoapache:masterfrom
yhs0092:support_access_log_extension_dev

Conversation

@yhs0092
Copy link
Copy Markdown
Member

@yhs0092 yhs0092 commented May 29, 2018

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See details in SCB-616.
The access log pattern parse mechanism is refactored, and now the creators of AccessLogItem is loaded by SPIServiceUtils.

@coveralls
Copy link
Copy Markdown

coveralls commented May 29, 2018

Coverage Status

Coverage decreased (-0.08%) to 87.418% when pulling 800c7cb on yhs0092:support_access_log_extension_dev into 517a9ff on apache:master.

@yhs0092 yhs0092 force-pushed the support_access_log_extension_dev branch from 9b90387 to 800c7cb Compare June 4, 2018 13:07
@wujimin wujimin merged commit b6ec548 into apache:master Jun 5, 2018
@yhs0092 yhs0092 deleted the support_access_log_extension_dev branch July 23, 2018 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants