Skip to content

[SCB-652] Fix schema register logic#757

Merged
liubao68 merged 2 commits intoapache:masterfrom
yhs0092:fix_schema_register_logic
Jun 11, 2018
Merged

[SCB-652] Fix schema register logic#757
liubao68 merged 2 commits intoapache:masterfrom
yhs0092:fix_schema_register_logic

Conversation

@yhs0092
Copy link
Copy Markdown
Member

@yhs0092 yhs0092 commented Jun 7, 2018

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See details in SCB-652

  • change environment config item from "instance_description.environment" to "service_description.environment"
  • improve schema compare and register logic

….environment and mark @deprecated onto microserviceInstance.environment
@yhs0092 yhs0092 closed this Jun 7, 2018
@yhs0092 yhs0092 reopened this Jun 7, 2018
@yhs0092 yhs0092 closed this Jun 8, 2018
@yhs0092 yhs0092 reopened this Jun 8, 2018
@yhs0092 yhs0092 force-pushed the fix_schema_register_logic branch from 12c4c5d to e12bb34 Compare June 11, 2018 05:33
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.03%) to 87.338% when pulling e12bb34 on yhs0092:fix_schema_register_logic into 8f420f1 on apache:master.

}

// Currently nothing to do but print a warning
LOGGER.warn("There are schemas only existing in service center: {}, which means there are interfaces changed. "
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change microservice version just only make it can deploy
but it's not compatible, it's better write something about this in log.

@liubao68 liubao68 merged commit 0a7966e into apache:master Jun 11, 2018
@yhs0092 yhs0092 deleted the fix_schema_register_logic branch July 23, 2018 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants