[SCB-716] Implementation of Local Service Registry Demo#791
[SCB-716] Implementation of Local Service Registry Demo#791wujimin merged 6 commits intoapache:masterfrom
Conversation
|
retrigger CI |
| @@ -0,0 +1,54 @@ | |||
| <?xml version="1.0"?> | |||
There was a problem hiding this comment.
Can you move these codes to samples folder? Java-chassis demo folder is for integration tests . We are planning to change it but got no time to deal this.
And add a README.md for this sample project to learn what it is done and how to run this sample.
There was a problem hiding this comment.
ok..i will move and raise PR.
…: moving code to sample folder
| public static void main(String[] args) { | ||
| System.setProperty("local.registry.file", "/yourpath/registry.yaml"); | ||
| //your code | ||
| System.clearProperty("local.registry.file"); |
There was a problem hiding this comment.
why we need a clear action?
There was a problem hiding this comment.
This is System property, better to clear after our work.
| @@ -0,0 +1,69 @@ | |||
| ## --------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
seems not a good schema id.
There was a problem hiding this comment.
ok, i will change schema id
|
|
||
| public class LocalRegistryServer { | ||
| public static void main(String[] args) throws Exception { | ||
| Log4jUtils.init(); |
There was a problem hiding this comment.
this sample means:
1.server connect to sc
2.client not connec to sc?
There was a problem hiding this comment.
- server will not connect SC
- client will not connect SC
client will connect server's APIs with help of local registry function.
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean installto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.