Skip to content

[SCB-716] Implementation of Local Service Registry Demo#791

Merged
wujimin merged 6 commits intoapache:masterfrom
maheshrajus:master
Jul 10, 2018
Merged

[SCB-716] Implementation of Local Service Registry Demo#791
wujimin merged 6 commits intoapache:masterfrom
maheshrajus:master

Conversation

@maheshrajus
Copy link
Copy Markdown
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@liubao68
Copy link
Copy Markdown
Contributor

liubao68 commented Jul 6, 2018

retrigger CI

@liubao68 liubao68 closed this Jul 6, 2018
@liubao68 liubao68 reopened this Jul 6, 2018
@@ -0,0 +1,54 @@
<?xml version="1.0"?>
Copy link
Copy Markdown
Contributor

@liubao68 liubao68 Jul 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move these codes to samples folder? Java-chassis demo folder is for integration tests . We are planning to change it but got no time to deal this.
And add a README.md for this sample project to learn what it is done and how to run this sample.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok..i will move and raise PR.

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 9, 2018

Coverage Status

Coverage decreased (-0.04%) to 87.155% when pulling 93a15bf on maheshrajus:master into 71d926c on apache:master.

public static void main(String[] args) {
   System.setProperty("local.registry.file", "/yourpath/registry.yaml");
//your code
   System.clearProperty("local.registry.file");
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we need a clear action?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is System property, better to clear after our work.

@@ -0,0 +1,69 @@
## ---------------------------------------------------------------------------
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems not a good schema id.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i will change schema id


public class LocalRegistryServer {
public static void main(String[] args) throws Exception {
Log4jUtils.init();
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this sample means:
1.server connect to sc
2.client not connec to sc?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. server will not connect SC
  2. client will not connect SC
    client will connect server's APIs with help of local registry function.

@wujimin wujimin merged commit 0c61dd9 into apache:master Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants