Merged
Conversation
WillemJiang
reviewed
Jul 17, 2018
| @@ -1,4 +1,4 @@ | |||
| /* | |||
| package org.apache.servicecomb.serviceregistry.registry;/* | |||
Member
There was a problem hiding this comment.
The package should add below the License header.
Contributor
Author
There was a problem hiding this comment.
oh, this happened randomly
do you know why......
wujimin
force-pushed
the
instance-cache-check
branch
2 times, most recently
from
f6c3e5e to
a8eec4a
Compare
added 5 commits
July 17, 2018 15:28
wujimin
force-pushed
the
instance-cache-check
branch
from
a8eec4a to
c7dbbd8
Compare
liubao68
approved these changes
Jul 18, 2018
WillemJiang
approved these changes
Jul 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.instance cache check task can be trigger periodically or manually
2.after check will post "InstanceCacheSummary" event, subscriber should subscrbe the event, and run their special logic